Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 703793002: Remove some testing of getPropertyCSSValue in fast/css/getComputedStyle (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove some testing of getPropertyCSSValue in fast/css/getComputedStyle As getPropertyCSSValue is no longer web-exposed we should stop testing it so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -147 lines) Patch
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size.html View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-slice-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-spacing.html View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-borderRadius.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-borderRadius-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js View 2 chunks +13 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-05 19:39:15 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-06 00:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703793002/1
6 years, 1 month ago (2014-11-06 00:07:56 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 00:34:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184888

Powered by Google App Engine
This is Rietveld 408576698