Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703753005: More Windows build fixes. (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
brettw, scottmg
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

More Windows build fixes. http_server and mojo_shell link and work. window_manager is blocked on a linking issue with angle. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/666877b906639354231e0739abbe5ca35e087ed7

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove generated files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64104 lines, -741 lines) Patch
M build/secondary/third_party/nss/BUILD.gn View 1 3 chunks +7 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/network/udp_socket_wrapper.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 1 3 chunks +11 lines, -14 lines 0 comments Download
M mojo/shell/dynamic_application_loader.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/http_server/http_server.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/iaccessible2/BUILD.gn View 1 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/iaccessible2/IAccessible2Proxy.def View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/iaccessible2/LICENSE View 1 1 chunk +50 lines, -0 lines 0 comments Download
A + third_party/iaccessible2/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/iaccessible2/README.chromium View 1 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/iaccessible2/ia2_api_all.idl View 1 1 chunk +5473 lines, -0 lines 0 comments Download
A third_party/iaccessible2/iaccessible2.gyp View 1 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/wtl/BUILD.gn View 1 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/wtl/Ms-PL.txt View 1 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/wtl/README.chromium View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlapp.h View 1 1 chunk +1686 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlcrack.h View 1 1 chunk +2377 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlctrls.h View 1 1 chunk +10036 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlctrlw.h View 1 1 chunk +4158 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlctrlx.h View 1 1 chunk +4824 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlddx.h View 1 1 chunk +621 lines, -0 lines 0 comments Download
A third_party/wtl/include/atldlgs.h View 1 1 chunk +6209 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlfind.h View 1 1 chunk +1033 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlframe.h View 1 1 chunk +3462 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlgdi.h View 1 1 chunk +3847 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlmisc.h View 1 1 chunk +4018 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlprint.h View 1 1 chunk +1110 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlres.h View 1 1 chunk +259 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlresce.h View 1 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlscrl.h View 1 1 chunk +2012 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlsplit.h View 1 1 chunk +889 lines, -0 lines 0 comments Download
A third_party/wtl/include/atltheme.h View 1 1 chunk +1215 lines, -0 lines 0 comments Download
A third_party/wtl/include/atluser.h View 1 1 chunk +1159 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlwince.h View 1 1 chunk +3007 lines, -0 lines 0 comments Download
A third_party/wtl/include/atlwinx.h View 1 1 chunk +526 lines, -0 lines 0 comments Download
A third_party/wtl/readme.htm View 1 1 chunk +3336 lines, -0 lines 0 comments Download
A third_party/wtl/using_wtl.vsprops View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
D ui/aura/remote_window_tree_host_win.h View 1 1 chunk +0 lines, -193 lines 0 comments Download
D ui/aura/remote_window_tree_host_win.cc View 1 1 chunk +0 lines, -524 lines 0 comments Download
A ui/native_theme/native_theme_win.h View 1 1 chunk +372 lines, -0 lines 0 comments Download
A ui/native_theme/native_theme_win.cc View 1 1 chunk +2068 lines, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jam
Scott: main reviewer Scott & Brett: I'm running into a problem building window_manager. It's complaining ...
6 years, 1 month ago (2014-11-05 16:27:13 UTC) #2
scottmg
lgtm I'm not sure about angle. I had some different errors in the angle code, ...
6 years, 1 month ago (2014-11-05 17:10:22 UTC) #3
jam
Committed patchset #2 (id:10001) manually as 666877b906639354231e0739abbe5ca35e087ed7.
6 years, 1 month ago (2014-11-05 18:35:36 UTC) #4
jam
6 years, 1 month ago (2014-11-05 18:44:35 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/703753005/diff/1/third_party/iaccessible2/IAc...
File third_party/iaccessible2/IAccessible2Proxy.vcxproj (right):

https://codereview.chromium.org/703753005/diff/1/third_party/iaccessible2/IAc...
third_party/iaccessible2/IAccessible2Proxy.vcxproj:1: <?xml version="1.0"
encoding="utf-8"?>
On 2014/11/05 17:10:22, scottmg wrote:
> the .vcxproj and .vcxproj.filters are generated files, they shouldn't be added

Done.

https://codereview.chromium.org/703753005/diff/1/third_party/iaccessible2/iac...
File third_party/iaccessible2/iaccessible2.sln (right):

https://codereview.chromium.org/703753005/diff/1/third_party/iaccessible2/iac...
third_party/iaccessible2/iaccessible2.sln:1: Microsoft Visual Studio Solution
File, Format Version 13.00
On 2014/11/05 17:10:22, scottmg wrote:
> and this one

Done.

Powered by Google App Engine
This is Rietveld 408576698