Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: ppapi/proxy/video_decoder_resource.h

Issue 703753002: Pepper: Expose visible_rect to PPB_VideoDecoder.GetPicture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/video_decoder_resource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/video_decoder_resource.h
diff --git a/ppapi/proxy/video_decoder_resource.h b/ppapi/proxy/video_decoder_resource.h
index 2e4ea6d5875d793f6ad938eff831b155faa71083..bcc8906980b1f3812f051f91b56eab0aa5c32fa6 100644
--- a/ppapi/proxy/video_decoder_resource.h
+++ b/ppapi/proxy/video_decoder_resource.h
@@ -56,6 +56,9 @@ class PPAPI_PROXY_EXPORT VideoDecoderResource
uint32_t size,
const void* buffer,
scoped_refptr<TrackedCallback> callback) override;
+ virtual int32_t GetPicture0_1(
+ PP_VideoPicture_0_1* picture,
+ scoped_refptr<TrackedCallback> callback) override;
virtual int32_t GetPicture(PP_VideoPicture* picture,
scoped_refptr<TrackedCallback> callback) override;
virtual void RecyclePicture(const PP_VideoPicture* picture) override;
@@ -96,19 +99,16 @@ class PPAPI_PROXY_EXPORT VideoDecoderResource
// Struct to hold a picture received from the decoder.
struct Picture {
- Picture(int32_t decode_id, uint32_t texture_id);
+ Picture(int32_t decode_id,
+ uint32_t texture_id,
+ const PP_Rect& visible_rect);
~Picture();
int32_t decode_id;
uint32_t texture_id;
+ PP_Rect visible_rect;
};
- int32_t InitializeInternal(PP_Resource graphics_context,
- PP_VideoProfile profile,
- PP_Bool allow_software_fallback,
- scoped_refptr<TrackedCallback> callback,
- bool testing);
-
// Unsolicited reply message handlers.
void OnPluginMsgRequestTextures(const ResourceMessageReplyParams& params,
uint32_t num_textures,
@@ -117,7 +117,8 @@ class PPAPI_PROXY_EXPORT VideoDecoderResource
const std::vector<gpu::Mailbox>& mailboxes);
void OnPluginMsgPictureReady(const ResourceMessageReplyParams& params,
int32_t decode_id,
- uint32_t texture_id);
+ uint32_t texture_id,
+ const PP_Rect& visible_rect);
void OnPluginMsgDismissPicture(const ResourceMessageReplyParams& params,
uint32_t texture_id);
void OnPluginMsgNotifyError(const ResourceMessageReplyParams& params,
@@ -132,7 +133,7 @@ class PPAPI_PROXY_EXPORT VideoDecoderResource
void RunCallbackWithError(scoped_refptr<TrackedCallback>* callback);
void DeleteGLTexture(uint32_t texture_id);
- void WriteNextPicture(PP_VideoPicture* picture);
+ void WriteNextPicture();
// ScopedVector to own the shared memory buffers.
ScopedVector<ShmBuffer> shm_buffers_;
@@ -169,6 +170,7 @@ class PPAPI_PROXY_EXPORT VideoDecoderResource
// State for pending get_picture_callback_.
PP_VideoPicture* get_picture_;
+ PP_VideoPicture_0_1* get_picture_0_1_;
ScopedPPResource graphics3d_;
gpu::gles2::GLES2Implementation* gles2_impl_;
« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/video_decoder_resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698