Pepper: Expose visible_rect to PPB_VideoDecoder.GetPicture.

ppapi/c/ppb_video_decoder.h

 /* Copyright (c) 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
-/* From ppb_video_decoder.idl modified Mon Sep  8 16:40:15 2014. */
+/* From ppb_video_decoder.idl modified Wed Nov  5 14:04:14 2014. */
 
 #ifndef PPAPI_C_PPB_VIDEO_DECODER_H_
 #define PPAPI_C_PPB_VIDEO_DECODER_H_
 
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_codecs.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_macros.h"
+#include "ppapi/c/pp_point.h"
+#include "ppapi/c/pp_rect.h"

[dmichael (off chromium), 2014/11/05 23:06:04]

Any idea why the IDL generator added these? Seems weird

[bbudge, 2014/11/06 00:26:36]

Seems like a bug. They are added to pp_codecs.h so not needed here.

 #include "ppapi/c/pp_resource.h"
 #include "ppapi/c/pp_size.h"
 #include "ppapi/c/pp_stdint.h"
 
 #define PPB_VIDEODECODER_INTERFACE_0_1 "PPB_VideoDecoder;0.1"
 #define PPB_VIDEODECODER_INTERFACE_0_2 "PPB_VideoDecoder;0.2"
-#define PPB_VIDEODECODER_INTERFACE PPB_VIDEODECODER_INTERFACE_0_2
+#define PPB_VIDEODECODER_INTERFACE_1_0 "PPB_VideoDecoder;1.0"
+#define PPB_VIDEODECODER_INTERFACE PPB_VIDEODECODER_INTERFACE_1_0
 
 /**
  * @file
  * This file defines the <code>PPB_VideoDecoder</code> interface.
  */
 
 
 /**
  * @addtogroup Interfaces
  * @{
@@ skipping 14 matching lines @@
  * - Call Reset() to quickly stop the decoder (e.g. to implement Seek) and wait
  *   for the callback before restarting decoding at another point.
  * - To destroy the decoder, the plugin should release all of its references to
  *   it. Any pending callbacks will abort before the decoder is destroyed.
  *
  * Available video codecs vary by platform.
  * All: theora, vorbis, vp8.
  * Chrome and ChromeOS: aac, h264.
  * ChromeOS: mpeg4.
  */
-struct PPB_VideoDecoder_0_2 {
+struct PPB_VideoDecoder_1_0 {
   /**
    * Creates a new video decoder resource.
    *
    * @param[in] instance A <code>PP_Instance</code> identifying the instance
    * with the video decoder.
    *
    * @return A <code>PP_Resource</code> corresponding to a video decoder if
    * successful or 0 otherwise.
    */
   PP_Resource (*Create)(PP_Instance instance);
@@ skipping 142 matching lines @@
    * @param[in] callback A <code>PP_CompletionCallback</code> to be called on
    * completion.
    *
    * @return An int32_t containing an error code from <code>pp_errors.h</code>.
    * Returns PP_ERROR_FAILED if the decoder isn't initialized.
    */
   int32_t (*Reset)(PP_Resource video_decoder,
                    struct PP_CompletionCallback callback);
 };
 
-typedef struct PPB_VideoDecoder_0_2 PPB_VideoDecoder;
+typedef struct PPB_VideoDecoder_1_0 PPB_VideoDecoder;
 
 struct PPB_VideoDecoder_0_1 {
   PP_Resource (*Create)(PP_Instance instance);
   PP_Bool (*IsVideoDecoder)(PP_Resource resource);
   int32_t (*Initialize)(PP_Resource video_decoder,
                         PP_Resource graphics3d_context,
                         PP_VideoProfile profile,
                         PP_Bool allow_software_fallback,
                         struct PP_CompletionCallback callback);
   int32_t (*Decode)(PP_Resource video_decoder,
                     uint32_t decode_id,
                     uint32_t size,
                     const void* buffer,
                     struct PP_CompletionCallback callback);
   int32_t (*GetPicture)(PP_Resource video_decoder,
-                        struct PP_VideoPicture* picture,
+                        struct PP_VideoPicture_0_1* picture,
                         struct PP_CompletionCallback callback);
   void (*RecyclePicture)(PP_Resource video_decoder,
                          const struct PP_VideoPicture* picture);
+  int32_t (*Flush)(PP_Resource video_decoder,
+                   struct PP_CompletionCallback callback);
+  int32_t (*Reset)(PP_Resource video_decoder,
+                   struct PP_CompletionCallback callback);
+};
+
+struct PPB_VideoDecoder_0_2 {
+  PP_Resource (*Create)(PP_Instance instance);
+  PP_Bool (*IsVideoDecoder)(PP_Resource resource);
+  int32_t (*Initialize)(PP_Resource video_decoder,
+                        PP_Resource graphics3d_context,
+                        PP_VideoProfile profile,
+                        PP_HardwareAcceleration acceleration,
+                        struct PP_CompletionCallback callback);
+  int32_t (*Decode)(PP_Resource video_decoder,
+                    uint32_t decode_id,
+                    uint32_t size,
+                    const void* buffer,
+                    struct PP_CompletionCallback callback);
+  int32_t (*GetPicture)(PP_Resource video_decoder,
+                        struct PP_VideoPicture_0_1* picture,
+                        struct PP_CompletionCallback callback);
+  void (*RecyclePicture)(PP_Resource video_decoder,
+                         const struct PP_VideoPicture* picture);
   int32_t (*Flush)(PP_Resource video_decoder,
                    struct PP_CompletionCallback callback);
   int32_t (*Reset)(PP_Resource video_decoder,
                    struct PP_CompletionCallback callback);
 };
 /**
  * @}
  */
 
 #endif  /* PPAPI_C_PPB_VIDEO_DECODER_H_ */