Pepper: Expose visible_rect to PPB_VideoDecoder.GetPicture.

ppapi/api/ppb_video_decoder.idl

 /* Copyright (c) 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the <code>PPB_VideoDecoder</code> interface.
  */
 
 [generate_thunk]
 
 label Chrome {
   /** Though not labeled 'channel=dev', 0.1 is a still a 'Dev' only API. */
   M36 = 0.1,
-  M39 = 0.2
+  M39 = 0.2,
+  M40 = 0.3

[dmichael (off chromium), 2014/11/05 19:28:08]

What do you think about calling this one 1.0?

[bbudge, 2014/11/05 22:41:48]

A little gun-shy now, but OK. Done.

 };
 
 /**
  * Video decoder interface.
  *
  * Typical usage:
  * - Call Create() to create a new video decoder resource.
  * - Call Initialize() to initialize it with a 3d graphics context and the
  *   desired codec profile.
  * - Call Decode() continuously (waiting for each previous call to complete) to
@@ skipping 149 matching lines @@
    *
    * @return An int32_t containing an error code from <code>pp_errors.h</code>.
    * Returns PP_ERROR_FAILED if the decoder isn't initialized or if a Reset()
    * call is pending.
    * Returns PP_ERROR_INPROGRESS if there is another GetPicture() call pending.
    * Returns PP_ERROR_ABORTED when Reset() is called, or if a call to Flush()
    * completes while GetPicture() is pending.
    */
   int32_t GetPicture(
       [in] PP_Resource video_decoder,
       [out] PP_VideoPicture picture,

[dmichael (off chromium), 2014/11/05 19:28:08]

We could just make a separate PP_VideoPicture_0_2 struct and use it here... 
even if the IDL generator doesn't allow versioning non-API structs. We could
even use a (0.3) PP_VideoPicture inside and copy to the right
PP_VideoPicture_0_2 at the last minute.

Looking at this, IMHO, the added complexity for us isn't that much, and the most
recent stable API would look better. WDYT?

[bbudge, 2014/11/05 22:41:47]

Redid the patch to define a new version of PP_VideoFrame.

       [in] PP_CompletionCallback callback);
 
   /**
+   * Gets the next picture from the decoder. The picture is valid after the
+   * decoder signals completion by returning PP_OK or running |callback|. The
+   * plugin can call GetPicture() again after the decoder signals completion.
+   * When the plugin is finished using the picture, it should return it to the
+   * system by calling RecyclePicture().
+   *
+   * @param[in] video_decoder A <code>PP_Resource</code> identifying the video
+   * decoder.
+   * @param[out] picture A <code>PP_VideoPicture</code> to hold the decoded
+   * picture.
+   * @param[out] visible_rect A <code>PP_Rect</code> to hold the visible
+   * subrectangle of the picture. The plugin should only display the visible
+   * area of the picture.
+   * @param[in] callback A <code>PP_CompletionCallback</code> to be called on
+   * completion.
+   *
+   * @return An int32_t containing an error code from <code>pp_errors.h</code>.
+   * Returns PP_ERROR_FAILED if the decoder isn't initialized or if a Reset()
+   * call is pending.
+   * Returns PP_ERROR_INPROGRESS if there is another GetPicture() call pending.
+   * Returns PP_ERROR_ABORTED when Reset() is called, or if a call to Flush()
+   * completes while GetPicture() is pending.
+   */
+  [version = 0.3]
+  int32_t GetPicture(
+      [in] PP_Resource video_decoder,
+      [out] PP_VideoPicture picture,
+      [out] PP_Rect visible_rect,
+      [in] PP_CompletionCallback callback);
+
+  /**
    * Recycles a picture that the plugin has received from the decoder.
    * The plugin should call this as soon as it has finished using the texture so
    * the decoder can decode more pictures.
    *
    * @param[in] video_decoder A <code>PP_Resource</code> identifying the video
    * decoder.
    * @param[in] picture A <code>PP_VideoPicture</code> to return to
    * the decoder.
    */
   void RecyclePicture(
@@ skipping 38 matching lines @@
    * @param[in] callback A <code>PP_CompletionCallback</code> to be called on
    * completion.
    *
    * @return An int32_t containing an error code from <code>pp_errors.h</code>.
    * Returns PP_ERROR_FAILED if the decoder isn't initialized.
    */
   int32_t Reset(
       [in] PP_Resource video_decoder,
       [in] PP_CompletionCallback callback);
 };