Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 70373002: Add initial auto-roll script. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add initial auto-roll script. To be called with a cron job. TEST=tools/push-to-trunk/auto_roll.py TODO: Add a revision filter to allow "MIPS" related changes to take over the lkgr. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17833

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -24 lines) Patch
A tools/push-to-trunk/auto_roll.py View 1 1 chunk +119 lines, -0 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 2 chunks +26 lines, -1 line 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 3 chunks +5 lines, -20 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 1 month ago (2013-11-12 15:37:05 UTC) #1
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/70373002/diff/1/tools/push-to-trunk/auto_roll.py File tools/push-to-trunk/auto_roll.py (right): https://codereview.chromium.org/70373002/diff/1/tools/push-to-trunk/auto_roll.py#newcode56 tools/push-to-trunk/auto_roll.py:56: log = self.Git("svn log -1 --oneline").strip() ...
7 years, 1 month ago (2013-11-18 13:27:08 UTC) #2
Michael Achenbach
https://codereview.chromium.org/70373002/diff/1/tools/push-to-trunk/auto_roll.py File tools/push-to-trunk/auto_roll.py (right): https://codereview.chromium.org/70373002/diff/1/tools/push-to-trunk/auto_roll.py#newcode56 tools/push-to-trunk/auto_roll.py:56: log = self.Git("svn log -1 --oneline").strip() On 2013/11/18 13:27:08, ...
7 years, 1 month ago (2013-11-18 13:39:09 UTC) #3
Michael Achenbach
7 years, 1 month ago (2013-11-18 14:10:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698