Fix infinite loop causing iterator to go out of bounds.

Fix infinite loop causing iterator to go out of bounds.

BUG=430252
Committed: https://crrev.com/f971997eb9062d6721c42249018f25df6f0279da
Cr-Commit-Position: refs/heads/master@{#302748}

[rsadam, 2014-11-05 01:21:35]

rsadam@chromium.org changed reviewers:
+ oshima@chromium.org

[rsadam, 2014-11-05 01:21:36]

Hi Oshima, PTAL!

[oshima, 2014-11-05 01:34:37]

https://codereview.chromium.org/703703004/diff/20001/ash/virtual_keyboard_con...
File ash/virtual_keyboard_controller.cc (right):

https://codereview.chromium.org/703703004/diff/20001/ash/virtual_keyboard_con...
ash/virtual_keyboard_controller.cc:80: ++iter) {
how about

for (ui::KeyboardDevice* device : keyboards) {
  if (has_internal_keyboard_ && has_external_keyboard_)
    break;

}

[rsadam, 2014-11-05 01:39:15]

Patchset #3 (id:40001) has been deleted

[rsadam, 2014-11-05 01:42:32]

https://codereview.chromium.org/703703004/diff/20001/ash/virtual_keyboard_con...
File ash/virtual_keyboard_controller.cc (right):

https://codereview.chromium.org/703703004/diff/20001/ash/virtual_keyboard_con...
ash/virtual_keyboard_controller.cc:80: ++iter) {
On 2014/11/05 01:34:37, oshima wrote:
> how about
> 
> for (ui::KeyboardDevice* device : keyboards) {
>   if (has_internal_keyboard_ && has_external_keyboard_)
>     break;
> 
> }

NInja complains if I make it a pointer, other than that, done!

[rsadam, 2014-11-05 01:58:54]

Used const KeyboardDevice&

[oshima, 2014-11-05 02:00:55]

lgtm

[rsadam, 2014-11-05 02:01:47]

The CQ bit was checked by rsadam@chromium.org

[commit-bot: I haz the power, 2014-11-05 02:02:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703703004/80001

[commit-bot: I haz the power, 2014-11-05 02:58:18]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-11-05 02:59:04]

Patchset 4 (id:??) landed as
https://crrev.com/f971997eb9062d6721c42249018f25df6f0279da
Cr-Commit-Position: refs/heads/master@{#302748}