Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 703643004: Revert of Do not interchange MOUSE_MOVED and MOUSE_DRAGGED events in Widget (Closed)

Created:
6 years, 1 month ago by tdanderson
Modified:
6 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not interchange MOUSE_MOVED and MOUSE_DRAGGED events in Widget (patchset #8 id:140001 of https://codereview.chromium.org/560053002/) Reason for revert: Responsible for the crash reported in crbug.com/430427. Relanding will require addressing crbug.com/431350 first. Original issue's description: > Do not interchange MOUSE_MOVED and MOUSE_DRAGGED events in Widget > > In Widget::OnMouseEvent(), do not handle MOUSE_MOVED > events as MOUSE_DRAGGED events, and do not handle > MOUSE_DRAGGED events as MOUSE_MOVED events; instead > trust that the mouse event type has been set correctly > before arriving at Widget. This also allows us to > remove the member |is_mouse_button_pressed_| > from Widget. > > BUG=412929, 412931 > TEST=WidgetTest.DragIntoView BUG=412929, 412931 TBR=sadrul@chromium.org Committed: https://crrev.com/f2d6fd8f14b22b4b15e5e8fd3ac2bb8141bef552 Cr-Commit-Position: refs/heads/master@{#303274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -92 lines) Patch
M ui/views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/widget/widget.cc View 9 chunks +21 lines, -10 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +0 lines, -78 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tdanderson
Created Revert of Do not interchange MOUSE_MOVED and MOUSE_DRAGGED events in Widget
6 years, 1 month ago (2014-11-07 18:28:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703643004/1
6 years, 1 month ago (2014-11-07 18:59:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 19:49:12 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 19:50:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2d6fd8f14b22b4b15e5e8fd3ac2bb8141bef552
Cr-Commit-Position: refs/heads/master@{#303274}

Powered by Google App Engine
This is Rietveld 408576698