Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 703643002: Fix layer cache memory leak (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix layer cache memory leak The issue was that, with caching disabled, the layer cache code was removing layers outside of a purge (i.e., in unlock) but not correctly cleaning up the GrPictureInfo objects (as is done in purgePlot). Committed: https://skia.googlesource.com/skia/+/b32f0ad89119625feedb4f0403bbbc94fae44668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/gpu/GrLayerCache.cpp View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years, 1 month ago (2014-11-04 14:32:47 UTC) #2
egdaniel
lgtm
6 years, 1 month ago (2014-11-04 14:35:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703643002/1
6 years, 1 month ago (2014-11-04 14:37:54 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 14:46:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as b32f0ad89119625feedb4f0403bbbc94fae44668

Powered by Google App Engine
This is Rietveld 408576698