Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 703623005: cros: Fix unit_tests crashes in GetBrand() on official builders (Closed)

Created:
6 years, 1 month ago by James Cook
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Albert Bodenhamer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cros: Fix unit_tests crashes in GetBrand() on official builders unit_tests do not have prefs, but branded builds on Chrome OS attempt to read the brand code out of a null g_browser_process->local_state(). Instead, we now return an empty brand code in tests. This reduces the number of crashing unit_tests on the official builders from ~300 to ~30. BUG=430266 Committed: https://crrev.com/8747d18fb89ca9470a6e66caca6607a0c02f0682 Cr-Commit-Position: refs/heads/master@{#302733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/google/google_brand_chromeos.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Ilya Sherman
LGTM
6 years, 1 month ago (2014-11-05 00:33:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703623005/1
6 years, 1 month ago (2014-11-05 00:36:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 01:29:18 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 01:30:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8747d18fb89ca9470a6e66caca6607a0c02f0682
Cr-Commit-Position: refs/heads/master@{#302733}

Powered by Google App Engine
This is Rietveld 408576698