Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 703613004: Stop using nacl private, and pthread private libs for gold.nexe (can use IRT). (Closed)

Created:
6 years, 1 month ago by jvoung (off chromium)
Modified:
6 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/nacl-binutils.git@master
Visibility:
Public.

Description

Stop using nacl private, and pthread private libs for gold.nexe (can use IRT). Not yet using the IRT open_resource instead of SRPC and name service, but at least use some more of the IRT for now. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3914 R=mseaborn@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/nacl-binutils.git;a=commit;h=47b418f55091173059fec541f1907bd39baddd8d

Patch Set 1 #

Total comments: 4

Patch Set 2 : leave pthread alone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M gold/Makefile.am View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gold/Makefile.in View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
6 years, 1 month ago (2014-11-07 02:30:01 UTC) #2
Mark Seaborn
LGTM, thanks https://codereview.chromium.org/703613004/diff/1/gold/Makefile.am File gold/Makefile.am (left): https://codereview.chromium.org/703613004/diff/1/gold/Makefile.am#oldcode51 gold/Makefile.am:51: NACLSRPCLIBS = -lsrpc -lplatform -limc -limc_syscalls -lgio ...
6 years, 1 month ago (2014-11-07 02:36:38 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/703613004/diff/1/gold/Makefile.am File gold/Makefile.am (left): https://codereview.chromium.org/703613004/diff/1/gold/Makefile.am#oldcode51 gold/Makefile.am:51: NACLSRPCLIBS = -lsrpc -lplatform -limc -limc_syscalls -lgio -lpthread On ...
6 years, 1 month ago (2014-11-07 16:24:06 UTC) #4
jvoung (off chromium)
6 years, 1 month ago (2014-11-07 16:25:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47b418f55091173059fec541f1907bd39baddd8d (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698