Classes: Fix issue with default constructor crash

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/api.h"
 #include "src/ast.h"
 #include "src/bailout-reason.h"
 #include "src/base/platform/platform.h"
@@ skipping 626 matching lines @@
     Scope* scope, AstNodeFactory<AstConstructionVisitor>* factory, int pos) {
   return factory->NewSuperReference(
       ThisExpression(scope, factory, pos)->AsVariableProxy(),
       pos);
 }
 
 Expression* ParserTraits::ClassExpression(
     const AstRawString* name, Expression* extends, Expression* constructor,
     ZoneList<ObjectLiteral::Property*>* properties, int start_position,
     int end_position, AstNodeFactory<AstConstructionVisitor>* factory) {
+  if (constructor == NULL) {
+    // Create default constructor.
+    Scope* scope = NewScope(parser_->scope_, FUNCTION_SCOPE);
+    // Set position and force eager compilation since lazy parsing tries to

[arv (Not doing code reviews), 2014/11/04 17:53:05]

This is not very good. Suggestions welcome.

[Dmitry Lomov (no reviews), 2014/11/04 18:06:07]

I believe we need a new kind of function: a flag on SharedFunctionInfo is in
order

+    // parse the content which does not exist.
+    scope->set_start_position(0);
+    scope->set_end_position(0);
+    scope->SetScopeName(name);
+    scope->ForceEagerCompilation();
+    constructor = factory->NewDefaultConstructor(name, ast_value_factory(),
+                                                 scope, RelocInfo::kNoPosition);
+  }
   return factory->NewClassLiteral(name, extends, constructor, properties,
                                   start_position, end_position);
 }
 
+
 Literal* ParserTraits::ExpressionFromLiteral(
     Token::Value token, int pos,
     Scanner* scanner,
     AstNodeFactory<AstConstructionVisitor>* factory) {
   switch (token) {
     case Token::NULL_LITERAL:
       return factory->NewNullLiteral(pos);
     case Token::TRUE_LITERAL:
       return factory->NewBooleanLiteral(true, pos);
     case Token::FALSE_LITERAL:
@@ skipping 4299 matching lines @@
 
   // We cannot internalize on a background thread; a foreground task will take
   // care of calling Parser::Internalize just before compilation.
 
   if (compile_options() == ScriptCompiler::kProduceParserCache) {
     if (result != NULL) *info_->cached_data() = recorder.GetScriptData();
     log_ = NULL;
   }
 }
 } }  // namespace v8::internal