Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 703603005: Classes: Fix issue with default constructor crash (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Fix issue with default constructor crash Instead of creating the default constructor in the runtime function we create it in the parser. BUG=v8:3661 LOG=Y R=dslomov

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Trying... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -37 lines) Patch
M src/full-codegen.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M src/parser.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/parser.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download
M src/preparser.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +23 lines, -30 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
arv (Not doing code reviews)
https://codereview.chromium.org/703603005/diff/20001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/703603005/diff/20001/src/parser.cc#newcode650 src/parser.cc:650: // Set position and force eager compilation since lazy ...
6 years, 1 month ago (2014-11-04 17:53:05 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/703603005/diff/20001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/703603005/diff/20001/src/parser.cc#newcode650 src/parser.cc:650: // Set position and force eager compilation since lazy ...
6 years, 1 month ago (2014-11-04 18:06:08 UTC) #4
arv (Not doing code reviews)
I tried a different approach in https://codereview.chromium.org/698073005/
6 years, 1 month ago (2014-11-04 20:31:19 UTC) #6
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-05 16:54:24 UTC) #7
Trying...

Powered by Google App Engine
This is Rietveld 408576698