Issue 703603003: Reland "Optimize function across closures."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 703603003: Reland "Optimize function across closures." (Closed)

Created:
6 years, 1 month ago by Yang

Modified:
6 years, 1 month ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Reland "Optimize function across closures." R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25142

Patch Set 2 : Fix #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -72 lines)			Patch
M	src/code-stubs-hydrogen.cc	View		1 chunk	+60 lines, -40 lines	0 comments	Download
M	src/compiler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/factory.cc	View	1	2 chunks	+12 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1	3 chunks	+4 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+18 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/runtime-profiler.cc	View	1	1 chunk	+2 lines, -17 lines	1 comment	Download
M	src/runtime/runtime-test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mvstanton

lgtm https://codereview.chromium.org/703603003/diff/20001/src/runtime-profiler.cc File src/runtime-profiler.cc (right): https://codereview.chromium.org/703603003/diff/20001/src/runtime-profiler.cc#newcode110 src/runtime-profiler.cc:110: function->AttemptConcurrentOptimization(); I like how this logic moved into ...

6 years, 1 month ago (2014-11-04 12:42:33 UTC) #3

Yang

6 years, 1 month ago (2014-11-05 11:12:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 25142 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 703603003: Reland "Optimize function across closures." (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix #

Messages