Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(141)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/tests/modules/instance-of-application.sky
Issue
703593003
:
Move exports from Document to Module (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set:
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/engine/bindings/core/v8/ScriptController.h
sky/engine/bindings/core/v8/ScriptController.cpp
sky/engine/core/app/AbstractModule.cpp
sky/engine/core/dom/Document.h
sky/engine/core/dom/Document.cpp
sky/engine/core/dom/Document.idl
sky/engine/core/frame/LocalDOMWindow.h
sky/engine/core/frame/LocalDOMWindow.cpp
sky/engine/core/html/imports/HTMLImportChild.h
sky/engine/core/html/imports/HTMLImportChild.cpp
sky/engine/core/html/imports/HTMLImportLoader.h
sky/engine/core/html/imports/HTMLImportLoader.cpp
sky/engine/core/html/parser/HTMLScriptRunner.cpp
sky/tests/modules/instance-of-application.sky
sky/tests/modules/instance-of-application-expected.txt
sky/tests/modules/instance-of-module.sky
sky/tests/modules/instance-of-module-expected.txt
sky/tests/modules/resources/instance-of-module-module.sky
View unified diff
|
Download patch
« sky/engine/bindings/core/v8/ScriptController.h
('K') |
« sky/engine/core/html/parser/HTMLScriptRunner.cpp
('k') |
sky/tests/modules/instance-of-application-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <html>
1 <html>
2 <import src="../resources/dump-as-text.sky" />
2 <import src="../resources/dump-as-text.sky" />
3
<import src="/mojo/public/sky/buffer.sky" as="buffer" />
4 <div id="result">FAIL</div>
3 <div id="result">FAIL</div>
5 <script>
4 <script>
6 document.getElementById("result").textContent =
5 document.getElementById("result").textContent =
7
buffer.Buffer ? "PASS" : "FAIL: buffer.Buffer is missing";
6
module instanceof Application ? 'PASS': 'FAIL: ' + module;
8 </script>
7 </script>
9 </html>
8 </html>
OLD
NEW
« sky/engine/bindings/core/v8/ScriptController.h
('K') |
« sky/engine/core/html/parser/HTMLScriptRunner.cpp
('k') |
sky/tests/modules/instance-of-application-expected.txt »
('j') |
no next file with comments »
Issue 703593003: Move exports from Document to Module (Closed)
Created 6 years, 1 month ago by abarth-chromium
Modified 6 years, 1 month ago
Reviewers: eseidel
Base URL: git@github.com:domokit/mojo.git@master
Comments: 1
This is Rietveld
408576698
Chromium Code Reviews
Issue 703593003:
Move exports from Document to Module (Closed)
Base URL: git@github.com:domokit/mojo.git@master