Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 703573002: Implement a MOJO_READ_DATA_FLAG_PEEK flag for data pipes. (Closed)

Created:
6 years, 1 month ago by Anand Mistry (off Chromium)
Modified:
6 years, 1 month ago
Reviewers:
jamesr, viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Implement a MOJO_READ_DATA_FLAG_PEEK flag for data pipes. MOJO_READ_DATA_FLAG_PEEK allows the user to read data from a pipe without removing it. The data will be available for the next read. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0bb2d538d59d14bf0a3c964747deaf7263a54043

Patch Set 1 #

Patch Set 2 : Test peek in 2-phase mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -64 lines) Patch
M mojo/edk/system/core_unittest.cc View 1 4 chunks +41 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M mojo/edk/system/local_data_pipe.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/local_data_pipe.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/local_data_pipe_unittest.cc View 26 chunks +181 lines, -51 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Anand Mistry (off Chromium)
6 years, 1 month ago (2014-11-04 02:28:07 UTC) #2
viettrungluu
LGTM, thanks!
6 years, 1 month ago (2014-11-04 02:38:44 UTC) #3
viettrungluu
Also, could you please file a bug to add support for this to the JavaScript, ...
6 years, 1 month ago (2014-11-04 02:41:12 UTC) #4
Anand Mistry (off Chromium)
On 2014/11/04 02:41:12, viettrungluu wrote: > Also, could you please file a bug to add ...
6 years, 1 month ago (2014-11-04 04:47:00 UTC) #5
viettrungluu
On 2014/11/04 04:47:00, Anand Mistry wrote: > On 2014/11/04 02:41:12, viettrungluu wrote: > > Also, ...
6 years, 1 month ago (2014-11-04 15:55:28 UTC) #6
Anand Mistry (off Chromium)
jamesr@chromium.org: For OWNERS approval as per https://github.com/domokit/mojo/wiki, and a request to be added as a ...
6 years, 1 month ago (2014-11-04 23:01:40 UTC) #8
jamesr
We don't have OWNERS in this world, send me your github account name and I'll ...
6 years, 1 month ago (2014-11-04 23:23:18 UTC) #9
Anand Mistry (off Chromium)
6 years, 1 month ago (2014-11-05 00:30:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0bb2d538d59d14bf0a3c964747deaf7263a54043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698