components/history/core/browser/url_database.cc - Issue 703553002: Allow systematic prefix search in bookmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/url_database.cc

Issue 703553002: Allow systematic prefix search in bookmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments at https://codereview.chromium.org/701553002/ Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/url_database.cc

diff --git a/components/history/core/browser/url_database.cc b/components/history/core/browser/url_database.cc

index 35307074cd7eeff399ea8d9627835aacef1f40fd..fc3bb945fa0b7f7aa69a44cfbe58688d577bf4f9 100644

--- a/components/history/core/browser/url_database.cc

+++ b/components/history/core/browser/url_database.cc

@@ -357,7 +357,8 @@ bool URLDatabase::FindShortestURLFromBase(const std::string& base,

bool URLDatabase::GetTextMatches(const base::string16& query,

URLRows* results) {

ScopedVector<query_parser::QueryNode> query_nodes;

- query_parser_.ParseQueryNodes(query, &query_nodes.get());

+ query_parser_.ParseQueryNodes(

+ query, query_parser::MatchingAlgorithm::DEFAULT, &query_nodes.get());

results->clear();

sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,