Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 703553002: Allow systematic prefix search in bookmarks. (Closed)

Created:
6 years, 1 month ago by Kibeom Kim (inactive)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow systematic prefix search in bookmarks. This CL allows the bookmark model's search to always use prefix search, even when terms are too short. BUG=415774 Committed: https://crrev.com/f1a7a37376ffcf694b93845be75a313af6e61e24 Cr-Commit-Position: refs/heads/master@{#302598}

Patch Set 1 #

Patch Set 2 : addressed comments at https://codereview.chromium.org/701553002/ #

Total comments: 2

Patch Set 3 : removed const #

Patch Set 4 : removed more const #

Patch Set 5 : put missing "M" back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -42 lines) Patch
M components/bookmarks/browser/bookmark_index.h View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M components/bookmarks/browser/bookmark_index.cc View 1 2 5 chunks +19 lines, -10 lines 0 comments Download
M components/bookmarks/browser/bookmark_index_unittest.cc View 1 2 4 chunks +78 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/history/core/browser/url_database.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/query_parser/query_parser.h View 1 2 3 4 3 chunks +19 lines, -3 lines 0 comments Download
M components/query_parser/query_parser.cc View 1 2 3 8 chunks +26 lines, -10 lines 0 comments Download
M components/query_parser/query_parser_unittest.cc View 1 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Kibeom Kim (inactive)
sky@: ptal "Patch set 1" here is identical to the "Patch set 1" at https://codereview.chromium.org/701553002/
6 years, 1 month ago (2014-11-04 01:29:20 UTC) #2
sky
LGTM https://codereview.chromium.org/703553002/diff/20001/components/query_parser/query_parser.h File components/query_parser/query_parser.h (right): https://codereview.chromium.org/703553002/diff/20001/components/query_parser/query_parser.h#newcode132 components/query_parser/query_parser.h:132: const MatchingAlgorithm matching_algorithm, Are we really using const ...
6 years, 1 month ago (2014-11-04 03:32:05 UTC) #3
Kibeom Kim (inactive)
https://codereview.chromium.org/703553002/diff/20001/components/query_parser/query_parser.h File components/query_parser/query_parser.h (right): https://codereview.chromium.org/703553002/diff/20001/components/query_parser/query_parser.h#newcode132 components/query_parser/query_parser.h:132: const MatchingAlgorithm matching_algorithm, On 2014/11/04 03:32:05, sky wrote: > ...
6 years, 1 month ago (2014-11-04 08:38:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703553002/60001
6 years, 1 month ago (2014-11-04 08:39:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703553002/80001
6 years, 1 month ago (2014-11-04 08:44:28 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-04 10:30:53 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 10:32:15 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f1a7a37376ffcf694b93845be75a313af6e61e24
Cr-Commit-Position: refs/heads/master@{#302598}

Powered by Google App Engine
This is Rietveld 408576698