Add cr clobber command.

Add cr clobber command.

This patch adds a 'clobber' command to cr which deletes all files
in the current output directory (except for the cr config file).

BUG=

Committed: https://crrev.com/51afc8502ff845e2ac4d032a019b75391ae4e894
Cr-Commit-Position: refs/heads/master@{#302581}

[petrcermak, 2014-11-04 01:10:01]

petrcermak@chromium.org changed reviewers:
+ skyostil@chromium.org

[petrcermak, 2014-11-04 01:10:02]

Hi, please have a look at my CL.

Thanks,
Petr

[Sami, 2014-11-04 01:17:47]

https://codereview.chromium.org/703533003/diff/1/tools/cr/cr/commands/clobber.py
File tools/cr/cr/commands/clobber.py (right):

https://codereview.chromium.org/703533003/diff/1/tools/cr/cr/commands/clobber...
tools/cr/cr/commands/clobber.py:13: The clober command removes all generated
files from the output directory.
typo: clobber

https://codereview.chromium.org/703533003/diff/1/tools/cr/cr/commands/clobber...
tools/cr/cr/commands/clobber.py:31: cr.Host.Execute(
Could you write this in python instead (i.e., with os.listdir and
shutil.rmtree)? I'm not completely sure using find like this would work on a mac
for instance.

[petrcermak, 2014-11-04 02:24:37]

Thanks for your comments. PTAL.

Petr

https://codereview.chromium.org/703533003/diff/1/tools/cr/cr/commands/clobber.py
File tools/cr/cr/commands/clobber.py (right):

https://codereview.chromium.org/703533003/diff/1/tools/cr/cr/commands/clobber...
tools/cr/cr/commands/clobber.py:13: The clober command removes all generated
files from the output directory.
On 2014/11/04 01:17:47, Sami wrote:
> typo: clobber

Done.

https://codereview.chromium.org/703533003/diff/1/tools/cr/cr/commands/clobber...
tools/cr/cr/commands/clobber.py:31: cr.Host.Execute(
On 2014/11/04 01:17:47, Sami wrote:
> Could you write this in python instead (i.e., with os.listdir and
> shutil.rmtree)? I'm not completely sure using find like this would work on a
mac
> for instance.

Done.

[Sami, 2014-11-04 04:40:40]

Thanks, lgtm!

https://codereview.chromium.org/703533003/diff/20001/tools/cr/cr/commands/clo...
File tools/cr/cr/commands/clobber.py (right):

https://codereview.chromium.org/703533003/diff/20001/tools/cr/cr/commands/clo...
tools/cr/cr/commands/clobber.py:37: if f != cr.base.client.CLIENT_CONFIG_PATH:
nit: I'd use an early-out instead to reduce the depth:

  if f == cr.base.client.CLIENT_CONFIG_PATH:
    continue

[petrcermak, 2014-11-04 05:45:16]

https://codereview.chromium.org/703533003/diff/20001/tools/cr/cr/commands/clo...
File tools/cr/cr/commands/clobber.py (right):

https://codereview.chromium.org/703533003/diff/20001/tools/cr/cr/commands/clo...
tools/cr/cr/commands/clobber.py:37: if f != cr.base.client.CLIENT_CONFIG_PATH:
On 2014/11/04 04:40:40, Sami wrote:
> nit: I'd use an early-out instead to reduce the depth:
> 
>   if f == cr.base.client.CLIENT_CONFIG_PATH:
>     continue

Done.

[petrcermak, 2014-11-04 05:45:20]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2014-11-04 05:46:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703533003/40001

[commit-bot: I haz the power, 2014-11-04 06:30:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 06:31:20]

Patchset 3 (id:??) landed as
https://crrev.com/51afc8502ff845e2ac4d032a019b75391ae4e894
Cr-Commit-Position: refs/heads/master@{#302581}