Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 70353003: Include pdfviewer in everything. (Closed)

Created:
7 years, 1 month ago by scroggo
Modified:
7 years, 1 month ago
Reviewers:
edisonn
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Include pdfviewer in everything. This simplifies the process for building pdfviewer. Now it can be built using ./gyp_skia make pdfviewer (ninja can also be used). R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=12288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gyp/everything.gyp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Any reason not to include pdfviewer in everything? This makes it easier to build locally, ...
7 years, 1 month ago (2013-11-12 20:48:20 UTC) #1
edisonn
On 2013/11/12 20:48:20, scroggo wrote: > Any reason not to include pdfviewer in everything? This ...
7 years, 1 month ago (2013-11-12 20:55:32 UTC) #2
scroggo
7 years, 1 month ago (2013-11-14 15:46:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698