Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 703493002: ozone: evdev: Squelch unknown key errors for mouse & digi from gestures (Closed)

Created:
6 years, 1 month ago by spang
Modified:
6 years, 1 month ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Squelch unknown key errors for mouse & digi from gestures These are uninteresting because they are not keyboard keys and because they are redundant with button presses & MT contacts in gestures. We could possibly pass on the "tool" used (BTN_TOOL_*) for touch, but we currently don't use it. BUG=none TEST=ran chrome on link_freon, no more "unknown key" errors Committed: https://crrev.com/9dfb808fd36af298ec090cfc7dc0f4b2d1325352 Cr-Commit-Position: refs/heads/master@{#302527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
6 years, 1 month ago (2014-11-03 22:54:39 UTC) #2
kpschoedel
LGTM We'd still get unknown key errors from joysticks and gamepads, though?
6 years, 1 month ago (2014-11-03 22:59:38 UTC) #3
spang
On 2014/11/03 22:59:38, kpschoedel wrote: > LGTM > > We'd still get unknown key errors ...
6 years, 1 month ago (2014-11-03 23:11:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703493002/1
6 years, 1 month ago (2014-11-03 23:22:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 00:09:50 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:10:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dfb808fd36af298ec090cfc7dc0f4b2d1325352
Cr-Commit-Position: refs/heads/master@{#302527}

Powered by Google App Engine
This is Rietveld 408576698