Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change

Source/core/html/HTMLFormControlElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 16 matching lines @@
 #include "core/html/FormAssociatedElement.h"
 #include "core/html/LabelableElement.h"
 
 namespace blink {
 
 class FormDataList;
 class HTMLFormElement;
 class ValidationMessageClient;
 
 enum CheckValidityEventBehavior { CheckValidityDispatchNoEvent, CheckValidityDispatchInvalidEvent };
+enum ValidityRecalcReason { ElementAddition, ElementRemoval, ElementModification };
 
 // HTMLFormControlElement is the default implementation of FormAssociatedElement,
 // and form-associated element implementations should use HTMLFormControlElement
 // unless there is a special reason.
 class HTMLFormControlElement : public LabelableElement, public FormAssociatedElement {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLFormControlElement);
 
 public:
     virtual ~HTMLFormControlElement();
     virtual void trace(Visitor*) override;
@@ skipping 88 matching lines @@
     virtual bool isKeyboardFocusable() const override;
     virtual bool shouldShowFocusRingOnMouseFocus() const;
     virtual bool shouldHaveFocusAppearance() const override final;
     virtual void dispatchBlurEvent(Element* newFocusedElement) override;
     virtual void dispatchFocusEvent(Element* oldFocusedElement, FocusType) override;
     virtual void willCallDefaultEventHandler(const Event&) override final;
 
     virtual void didRecalcStyle(StyleRecalcChange) override final;
 
     // This must be called any time the result of willValidate() has changed.
-    void setNeedsWillValidateCheck();
+    void setNeedsWillValidateCheck(bool = true);

[tkent, 2014/11/06 04:44:57]

I couldn't find setNeedsWillValidateCheck callsites with false argument.

[Bartek Nowierski, 2014/11/06 07:15:44]

Good catch! In one place where I'm calling with true I should be calling with
false. Fixed.

[tkent, 2014/11/07 00:15:19]

I see.
nit: Because we don't like bool arguments (#10 of
http://www.chromium.org/blink/coding-style#TOC-Names), I recommend to have two
functions like setNeedsWillValidateCheck() and
setNeedsWillValidateCheckAndHideValidationMessage().

[Bartek Nowierski, 2014/11/12 22:23:56]

We don't like bool arguments more than we don't like code duplication??

Anyway, I removed the parameter per your other comment, so problem solved :)

[tkent, 2014/11/13 01:15:02]

I meant something like:

void setNeedsWillValidateCheck() { ...}
void setNeedsWillValidateCheckAndHideValidationMessage()
{
    setNeedsWillValidateCheck();
    hideVisibleValidationMessage();
}

[Bartek Nowierski, 2014/11/13 01:38:52]

Oh. But then we'll lose the m_willValidate check and we'd call
hideVisibleValidationMessage() when we shouldn't. We could work it around by
returning m_willValidate from setNeedsWillValidateCheck(), but I don't think
it's any cleaner than what I had.

     virtual bool recalcWillValidate() const;
 
     virtual void resetImpl() { }
     virtual bool supportsAutofocus() const;
 
 private:
 #if !ENABLE(OILPAN)
     virtual void refFormAssociatedElement() override final { ref(); }
     virtual void derefFormAssociatedElement() override final { deref(); }
 #endif
 
     virtual bool isFormControlElement() const override final { return true; }
     virtual bool alwaysCreateUserAgentShadowRoot() const override { return true; }
 
     virtual short tabIndex() const override final;
 
     virtual bool isDefaultButtonForForm() const override final;
     virtual bool isValidElement() override;
     virtual bool matchesValidityPseudoClasses() const override;
     void updateAncestorDisabledState() const;
 
     bool isValidationMessageVisible() const;
     ValidationMessageClient* validationMessageClient() const;
 
     // Requests validity recalc for the form owner, if one exists.
-    void formOwnerSetNeedsValidityCheck();
+    // In case of removal, isValid specifies element validity upon removal.
+    // In case of addition and modification, it specified new validity.
+    void formOwnerSetNeedsValidityCheck(ValidityRecalcReason, bool isValid);
     // Requests validity recalc for all ancestor fieldsets, if exist.
     void fieldSetAncestorsSetNeedsValidityCheck(Node*);
 
     bool m_disabled : 1;
     bool m_isAutofilled : 1;
     bool m_isReadOnly : 1;
     bool m_isRequired : 1;
     bool m_hasValidationMessage : 1;
 
     enum AncestorDisabledState { AncestorDisabledStateUnknown, AncestorDisabledStateEnabled, AncestorDisabledStateDisabled };
@@ skipping 19 matching lines @@
 {
     return element.isFormControlElement();
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, control->isFormControlElement(), control.isFormControlElement());
 
 } // namespace
 
 #endif