Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703463002: Improve quality of distance field rendering (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Improve quality of distance field rendering - Update spacing of LODs to get better results scaling up to 256 - Remove unnecessary "bolding" from dftext - Add debug colors for dftext LODs BUG=skia:2933, skia:2935 Committed: https://skia.googlesource.com/skia/+/ada68ef2dc986478288a8b8ad867fd3aca431162

Patch Set 1 #

Patch Set 2 : Ignore GMs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +15 lines, -3 lines 1 comment Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
6 years, 1 month ago (2014-11-03 21:23:02 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/703463002/diff/20001/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/703463002/diff/20001/src/gpu/GrDistanceFieldTextContext.cpp#newcode156 src/gpu/GrDistanceFieldTextContext.cpp:156: #if DEBUG_TEXT_SIZE cool!
6 years, 1 month ago (2014-11-03 21:45:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703463002/20001
6 years, 1 month ago (2014-11-03 21:52:07 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:00:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as ada68ef2dc986478288a8b8ad867fd3aca431162

Powered by Google App Engine
This is Rietveld 408576698