Plugin Power Saver: Add some UMAs to test plugins in wild.

content/renderer/pepper/pepper_plugin_instance_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
 #define CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
 
 #include <list>
 #include <set>
 #include <string>
@@ skipping 670 matching lines @@
   bool LockMouse();
   MouseLockDispatcher* GetMouseLockDispatcher();
   MouseLockDispatcher::LockTarget* GetOrCreateLockTargetAdapter();
   void UnSetAndDeleteLockTargetAdapter();
 
   void DidDataFromWebURLResponse(const blink::WebURLResponse& response,
                                  int pending_host_id,
                                  const ppapi::URLResponseInfoData& data);
 
   void SetPluginThrottled(bool throttled);
-  void DisablePowerSaverAndUnthrottle();
+  void DisablePowerSaverByRetroactiveWhitelist();
 
   RenderFrameImpl* render_frame_;
   base::Closure instance_deleted_callback_;
   scoped_refptr<PluginModule> module_;
   scoped_ptr<ppapi::PPP_Instance_Combined> instance_interface_;
   // If this is the NaCl plugin, we create a new module when we switch to the
   // IPC-based PPAPI proxy. Store the original module and instance interface
   // so we can shut down properly.
   scoped_refptr<PluginModule> original_module_;
   scoped_ptr<ppapi::PPP_Instance_Combined> original_instance_interface_;
 
   PP_Instance pp_instance_;
 
   // NULL until we have been initialized.
   blink::WebPluginContainer* container_;
   scoped_refptr<cc::Layer> compositor_layer_;
   scoped_refptr<cc::TextureLayer> texture_layer_;
   scoped_ptr<blink::WebLayer> web_layer_;
   bool layer_bound_to_fullscreen_;
   bool layer_is_hardware_;
 
   // Plugin URL.
   GURL plugin_url_;
 
   // Indicates whether this plugin may be throttled to reduce power consumption.
+  // |power_saver_enabled_| implies |is_peripheral_content_|.
   bool power_saver_enabled_;
 
+  // Indicates whether this plugin was found to be peripheral content.
+  // This is separately tracked from |power_saver_enabled_| to collect UMAs.
+  // Always true if |power_saver_enabled_| is true.
+  bool is_peripheral_content_;
+
   // Indicates if the plugin is currently throttled.
   bool plugin_throttled_;
 
   // Fake view data used by the Power Saver feature to throttle plugins.
   const ppapi::ViewData empty_view_data_;
 
   // Responsible for turning on throttling if Power Saver is on.
   scoped_ptr<PepperPluginInstanceThrottler> throttler_;

[raymes, 2014/11/06 02:11:00]

There's a growing number of power-saver related members and logic here. How do
you feel about factoring this out into a helper class? This class is already too
big and complex so any effort in keeping it smaller is much appreciated!

I'm ok with this being done in a followup CL.

A plausible interface for this class could be something like:

class PepperPluginPowerSaver {
 public:
  PepperPluginPowerSaver(PepperPluginInstanceImpl* instance, ...);

  bool is_throttled();
  const ppapi::ViewData& throttled_view_data();

  // Consumes an input event if the plugin is throttled and returns true.
  // (this would contain all the logic in HandleInputEvent)
  bool ConsumeInputEvent(const blink::WebInputEvent& event);

 private:
  void SetPluginThrottled(bool throttled) {
    ...
    instance_->SendDidChangeView)();
  }
  void DisablePowerSaverAndUnthrottle();

  bool power_saver_enabled_;
  bool is_peripheral_content_;
  bool plugin_throttled_;

  // Consider just combining this class with the throttler.
  scoped_ptr<PepperPluginInstanceThrottler> throttler_;
  
}

[tommycli, 2014/11/06 21:16:13]

No problem. I realize I'm adding a bunch of junk. I'll clean it all up in a
followup CL, promise.

 
   // Indicates whether this is a full frame instance, which means it represents
   // an entire document rather than an embed tag.
   bool full_frame_;
 
   // Stores the current state of the plugin view.
   ppapi::ViewData view_data_;
   // The last state sent to the plugin. It is only valid after
   // |sent_initial_did_change_view_| is set to true.
   ppapi::ViewData last_sent_view_data_;
@@ skipping 186 matching lines @@
   // view change events.
   base::WeakPtrFactory<PepperPluginInstanceImpl> view_change_weak_ptr_factory_;
   base::WeakPtrFactory<PepperPluginInstanceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperPluginInstanceImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_