Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(180)

Issue 7034027: Merge 86768 - 2011-05-18 Pavel Feldman <pfeldman@google.com> (Closed)

Created:
8 years, 3 months ago by apavlov
Modified:
8 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 86768 - 2011-05-18 Pavel Feldman <pfeldman@google.com>; Reviewed by Yury Semikhatsky. Web Inspector: [REGRESSION] Completion while on a breakpoint is not working. https://bugs.webkit.org/show_bug.cgi?id=60811 * inspector/debugger/debugger-completions-on-call-frame-expected.txt: Added. * inspector/debugger/debugger-completions-on-call-frame.html: Added. 2011-05-18 Pavel Feldman <pfeldman@google.com>; Reviewed by Yury Semikhatsky. Web Inspector: [REGRESSION] Completion while on a breakpoint is not working. https://bugs.webkit.org/show_bug.cgi?id=60811 Test: inspector/debugger/debugger-completions-on-call-frame.html * inspector/InjectedScriptSource.js: * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.else.evaluated): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.PresenationCallFrame.prototype.get variables): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.selectedCallFrameVariables): TBR=pfeldman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
A + LayoutTests/inspector/debugger/debugger-completions-on-call-frame.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/debugger/debugger-completions-on-call-frame-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/inspector/front-end/ConsoleView.js View 3 chunks +23 lines, -7 lines 0 comments Download
M Source/WebCore/inspector/front-end/RemoteObject.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/WebCore/inspector/front-end/ScriptsPanel.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
8 years, 3 months ago (2011-05-18 16:29:10 UTC) #1
pfeldman
8 years, 3 months ago (2011-05-18 17:00:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698