Issue 703383002: Prevent firing BeforeUnloadEvents re-entrantly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 703383002: Prevent firing BeforeUnloadEvents re-entrantly (Closed)

Created:
6 years, 1 month ago by Nate Chapin

Modified:
6 years, 1 month ago

Reviewers:
dglazkov

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Prevent firing BeforeUnloadEvents re-entrantly This can happen when an onbeforeunload listener calls window.close(). Have a re-entrant invocation pretend that the user blocked the navigation, so that we can consistently obey the user's intent on the original invocation. BUG=430507 TEST=http/tests/misc/reentrant-beforeunload.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184985

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -0 lines)			Patch
A	LayoutTests/http/tests/misc/reentrant-beforeunload.html	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/misc/reentrant-beforeunload-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/misc/resources/reentrant-beforeunload-helper.html	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703383002/1

6 years, 1 month ago (2014-11-07 18:26:22 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-07 19:16:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184985

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages