Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 703333005: DevTools: Tethering in Android Webview (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Tethering in Android Webview BUG=416154 Committed: https://crrev.com/fe519c64c25793e715677d0583b9a8980e84ac56 Cr-Commit-Position: refs/heads/master@{#304014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M android_webview/native/aw_dev_tools_server.cc View 3 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vkuzkokov
Tested with AndroidWebView.apk
6 years, 1 month ago (2014-11-12 12:55:21 UTC) #2
dgozman
+mnaganov for owner review lgtm
6 years, 1 month ago (2014-11-12 14:09:32 UTC) #5
mnaganov (inactive)
LGTM! Thanks, guys.
6 years, 1 month ago (2014-11-12 18:45:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703333005/1
6 years, 1 month ago (2014-11-13 10:40:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 11:28:50 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 11:29:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe519c64c25793e715677d0583b9a8980e84ac56
Cr-Commit-Position: refs/heads/master@{#304014}

Powered by Google App Engine
This is Rietveld 408576698