Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 70333002: Merged r17441 into 3.20 branch. (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow
Modified:
7 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Merged r17441 into 3.20 branch. Fix uint32-to-smi conversion in Lithium BUG=chromium:309623 R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -22 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/hydrogen-uint32-analysis.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +12 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-309623.js View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
7 years, 1 month ago (2013-11-12 15:15:58 UTC) #1
ulan
LGTM
7 years, 1 month ago (2013-11-12 15:27:20 UTC) #2
Jakob Kummerow
7 years, 1 month ago (2013-11-12 15:28:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698