Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 703323002: Continue removing testing of getPropertyCSSValue (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Continue removing testing of getPropertyCSSValue As getPropertyCSSValue is no longer web-exposed, we should stop testing it so we can delete the interface. Instead of using getPropertyCSSValue and calling cssText on the returned value, we can use getPropertyValue or the direct accessors. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184988

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -109 lines) Patch
M LayoutTests/editing/shadow/contenteditable-propagation-at-shadow-boundary.html View 2 chunks +1 line, -11 lines 0 comments Download
M LayoutTests/editing/shadow/contenteditable-propagation-at-shadow-boundary-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/border-width-large.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/border-width-large-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-font.js View 2 chunks +0 lines, -38 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/inherited-properties-explicit.html View 1 chunk +7 lines, -8 lines 0 comments Download
M LayoutTests/fast/css/inherited-properties-explicit-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/css/inherited-properties-rare-text.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/css/large-value-csstext.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-06 21:38:25 UTC) #2
alancutter (OOO until 2018)
lgtm, looks like some virtual expectations to update still.
6 years, 1 month ago (2014-11-07 07:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703323002/20001
6 years, 1 month ago (2014-11-07 18:17:30 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 20:26:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184988

Powered by Google App Engine
This is Rietveld 408576698