Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 703273002: Update mojo sdk to rev 04a510fb37db10642e156957f9b2c11c2f6442ac (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, arv+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, hansmuller
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev 04a510fb37db10642e156957f9b2c11c2f6442ac This updates the mojo sdk and updates chromium code to match. The most significant change is updating references to the mojo JS bindings code, which reshuffled. This part was reviewed separately by hansmuller@ in https://codereview.chromium.org/693343003/. This also updates ipc/mojo to reflect changes in ChannelInfo. R=morrita@chromium.org for ipc/mojo R=jam@chromium.org for top-level approval of the rest Committed: https://crrev.com/60a7dbf7faabe2a3b8caf306d8d2a01bfdcd5b59 Cr-Commit-Position: refs/heads/master@{#303149}

Patch Set 1 #

Patch Set 2 : remove mojo/bindings/js #

Patch Set 3 : Fix content/child -> mojo/common linking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1789 lines, -4708 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/omnibox/omnibox.js View 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/content_child.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_resources.grd View 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/web_ui_mojo.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_test_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_test_base.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/async_waiter.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/data_receiver.js View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/resources/data_sender.js View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/resources/keep_alive.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/serial_service.js View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/data/api_test_base_unittest.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 1 chunk +1 line, -6 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_readers.h View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D mojo/bindings/js/BUILD.gn View 1 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/bindings/js/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/bindings/js/core.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/bindings/js/core.cc View 1 1 chunk +0 lines, -321 lines 0 comments Download
D mojo/bindings/js/drain_data.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/bindings/js/drain_data.cc View 1 1 chunk +0 lines, -131 lines 0 comments Download
D mojo/bindings/js/handle.h View 1 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/bindings/js/handle.cc View 1 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/bindings/js/handle_close_observer.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/bindings/js/support.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/bindings/js/support.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/bindings/js/tests/BUILD.gn View 1 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/bindings/js/tests/DEPS View 1 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/bindings/js/tests/run_js_tests.cc View 1 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/bindings/js/waiting_callback.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/bindings/js/waiting_callback.cc View 1 1 chunk +0 lines, -95 lines 0 comments Download
D mojo/edk/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/edk/embedder/channel_info_forward.h View 1 chunk +31 lines, -0 lines 0 comments Download
M mojo/edk/embedder/channel_init.h View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 3 chunks +7 lines, -11 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 7 chunks +11 lines, -20 lines 0 comments Download
A + mojo/edk/js/BUILD.gn View 1 2 chunks +11 lines, -2 lines 0 comments Download
A + mojo/edk/js/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/core.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/core.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/edk/js/drain_data.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/drain_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/edk/js/handle.h View 1 3 chunks +15 lines, -0 lines 0 comments Download
A + mojo/edk/js/handle.cc View 1 3 chunks +32 lines, -2 lines 0 comments Download
A + mojo/edk/js/handle_close_observer.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/edk/js/handle_unittest.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A + mojo/edk/js/support.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/edk/js/support.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/edk/js/tests/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
A mojo/edk/js/tests/DEPS View 1 1 chunk +7 lines, -0 lines 0 comments Download
A + mojo/edk/js/tests/run_js_tests.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
A + mojo/edk/js/waiting_callback.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/edk/js/waiting_callback.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/mojo_edk.gyp View 5 chunks +51 lines, -0 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/edk/system/channel_info.h View 1 chunk +31 lines, -0 lines 0 comments Download
A mojo/edk/system/channel_info.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 4 chunks +41 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M mojo/edk/system/local_data_pipe.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/local_data_pipe.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/local_data_pipe_unittest.cc View 26 chunks +181 lines, -51 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +1 line, -19 lines 0 comments Download
M mojo/mojo_base.gyp View 1 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/public/BUILD.gn View 3 chunks +9 lines, -1 line 0 comments Download
M mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/c/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 4 chunks +10 lines, -2 lines 0 comments Download
D mojo/public/cpp/PRESUBMIT.py View 1 chunk +0 lines, -16 lines 0 comments Download
M mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/application_test_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
A mojo/public/cpp/environment/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/public/cpp/environment/async_waiter.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + mojo/public/cpp/environment/lib/async_waiter.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M mojo/public/cpp/environment/tests/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A + mojo/public/cpp/environment/tests/async_wait_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 6 chunks +25 lines, -32 lines 0 comments Download
A + mojo/public/dart/BUILD.gn View 1 chunk +13 lines, -7 lines 0 comments Download
A mojo/public/dart/README View 1 chunk +41 lines, -0 lines 0 comments Download
A + mojo/public/dart/bindings.dart View 1 chunk +7 lines, -9 lines 0 comments Download
A mojo/public/dart/src/codec.dart View 1 chunk +745 lines, -0 lines 0 comments Download
A + mojo/public/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/js/bindings/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/public/js/bindings/buffer.js View 1 chunk +0 lines, -156 lines 0 comments Download
D mojo/public/js/bindings/codec.js View 1 chunk +0 lines, -792 lines 0 comments Download
D mojo/public/js/bindings/codec_unittests.js View 1 chunk +0 lines, -258 lines 0 comments Download
D mojo/public/js/bindings/connection.js View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/public/js/bindings/connector.js View 1 chunk +0 lines, -127 lines 0 comments Download
D mojo/public/js/bindings/constants.h View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/js/bindings/constants.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/public/js/bindings/core.js View 1 chunk +0 lines, -229 lines 0 comments Download
D mojo/public/js/bindings/core_unittests.js View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/public/js/bindings/router.js View 1 chunk +0 lines, -135 lines 0 comments Download
D mojo/public/js/bindings/struct_unittests.js View 1 chunk +0 lines, -169 lines 0 comments Download
D mojo/public/js/bindings/support.js View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/js/bindings/tests/validation_test_input_parser.js View 1 chunk +0 lines, -299 lines 0 comments Download
D mojo/public/js/bindings/unicode.js View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/js/bindings/validation_unittests.js View 1 chunk +0 lines, -302 lines 0 comments Download
D mojo/public/js/bindings/validator.js View 1 chunk +0 lines, -356 lines 0 comments Download
A + mojo/public/js/buffer.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/codec.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/public/js/codec_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/connection.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/public/js/connector.js View 2 chunks +7 lines, -5 lines 0 comments Download
A + mojo/public/js/constants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/js/constants.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A + mojo/public/js/core.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/core_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/router.js View 7 chunks +22 lines, -19 lines 0 comments Download
A + mojo/public/js/struct_unittests.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/js/support.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/test/validation_test_input_parser.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/unicode.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/validation_unittests.js View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/public/js/validator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/mojo.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/mojo_public.gyp View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/python/mojo/bindings/descriptor.py View 3 chunks +84 lines, -31 lines 0 comments Download
M mojo/public/python/mojo/bindings/messaging.py View 4 chunks +13 lines, -2 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 5 chunks +43 lines, -8 lines 0 comments Download
M mojo/public/sky/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/public/sky/convert_amd_modules_to_sky.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 4 chunks +12 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 chunk +8 lines, -11 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_python_generator.py View 3 chunks +14 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/network/udp_socket_wrapper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +7 lines, -1 line 0 comments Download
M ui/keyboard/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/keyboard_mojo.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jamesr
morrita@ - please check the ipc/mojo changes jam@ - please check the rest hansmuller@ already ...
6 years, 1 month ago (2014-11-06 19:10:03 UTC) #2
jamesr
I removed the rest of the references to mojo/bindings/js in favor of mojo/edk/js since the ...
6 years, 1 month ago (2014-11-06 20:40:29 UTC) #3
gmorrita
ipc/mojo lgtm.
6 years, 1 month ago (2014-11-06 23:03:45 UTC) #5
jam
lgtm
6 years, 1 month ago (2014-11-07 00:01:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703273002/40001
6 years, 1 month ago (2014-11-07 00:13:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-07 01:25:00 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 01:25:38 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60a7dbf7faabe2a3b8caf306d8d2a01bfdcd5b59
Cr-Commit-Position: refs/heads/master@{#303149}

Powered by Google App Engine
This is Rietveld 408576698