Issue 7032005: Unify markbits for old and new spaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7032005: Unify markbits for old and new spaces. (Closed)

Created:
9 years, 7 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Unify markbits for old and new spaces. Committed: http://code.google.com/p/v8/source/detail?r=7911

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -250 lines)			Patch
M	src/assembler.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32-inl.h	View	8 chunks	+19 lines, -40 lines	0 comments	Download
M	src/incremental-marking.cc	View	5 chunks	+4 lines, -11 lines	0 comments	Download
M	src/mark-compact.h	View	2 chunks	+3 lines, -59 lines	0 comments	Download
M	src/mark-compact.cc	View	30 chunks	+32 lines, -59 lines	0 comments	Download
M	src/mark-compact-inl.h	View	1 chunk	+1 line, -36 lines	0 comments	Download
M	src/serialize.cc	View	1 chunk	+2 lines, -6 lines	2 comments	Download
M	src/spaces.h	View	5 chunks	+17 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

lgtm http://codereview.chromium.org/7032005/diff/1/src/serialize.cc File src/serialize.cc (right): http://codereview.chromium.org/7032005/diff/1/src/serialize.cc#newcode410 src/serialize.cc:410: 15, Don't we need a 14 any more?

9 years, 7 months ago (2011-05-16 18:44:49 UTC) #2

Vyacheslav Egorov (Chromium)

9 years, 7 months ago (2011-05-17 11:18:32 UTC) #3

landing

http://codereview.chromium.org/7032005/diff/1/src/serialize.cc
File src/serialize.cc (right):

http://codereview.chromium.org/7032005/diff/1/src/serialize.cc#newcode410
src/serialize.cc:410: 15,
On 2011/05/16 18:44:49, Erik Corry wrote:
> Don't we need a 14 any more?

Reverted.

Expand Messages | Collapse Messages