Issue 703193003: sync setup: move mistaken local statics to instance members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 703193003: sync setup: move mistaken local statics to instance members. (Closed)

Created:
6 years, 1 month ago by Dan Beam

Modified:
6 years, 1 month ago

Reviewers:
dcheng

CC:
arv+watch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@ok-cancel

Project:
chromium

Visibility:
Public.

sync setup: move mistaken local statics to instance members. Depends on https://codereview.chromium.org/702323002/ R=dcheng@chromium.org BUG=none TEST=dbeam@'s eyes bleed less Committed: https://crrev.com/f638ea2fcdb5d1f986ef803f45c157742b3e400f Cr-Commit-Position: refs/heads/master@{#303292}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -59 lines)			Patch
	M	chrome/browser/resources/sync_setup_overlay.js	View		13 chunks	+83 lines, -59 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703193003/1

6 years, 1 month ago (2014-11-07 20:09:46 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-07 20:57:24 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f638ea2fcdb5d1f986ef803f45c157742b3e400f
Cr-Commit-Position: refs/heads/master@{#303292}