[fsp] Pass more detailed errors to the providing extension.

chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"
 
 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"
 #include "chrome/browser/chromeos/file_system_provider/request_manager.h"
 #include "chrome/browser/chromeos/file_system_provider/request_value.h"
 #include "chrome/browser/chromeos/file_system_provider/service.h"
@@ skipping 108 matching lines @@
       FileErrorToProviderError(error));
 }
 
 FileSystemProviderInternalFunction::FileSystemProviderInternalFunction()
     : request_id_(0), request_manager_(NULL) {
 }
 
 bool FileSystemProviderInternalFunction::RejectRequest(
     scoped_ptr<chromeos::file_system_provider::RequestValue> value,
     base::File::Error error) {
-  if (!request_manager_->RejectRequest(request_id_, value.Pass(), error)) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
-    SendResponse(false);
+  const base::File::Error result =
+      request_manager_->RejectRequest(request_id_, value.Pass(), error);
+  if (result != base::File::FILE_OK) {
+    SetError(FileErrorToString(result));
     return false;
   }
 
   return true;
 }
 
 bool FileSystemProviderInternalFunction::FulfillRequest(
     scoped_ptr<RequestValue> value,
     bool has_more) {
-  if (!request_manager_->FulfillRequest(request_id_, value.Pass(), has_more)) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
-    SendResponse(false);
+  const base::File::Error result =
+      request_manager_->FulfillRequest(request_id_, value.Pass(), has_more);
+  if (result != base::File::FILE_OK) {
+    SetError(FileErrorToString(result));
     return false;
   }
 
   return true;
 }
 
 bool FileSystemProviderInternalFunction::RunSync() {
   DCHECK(args_);
   if (!Parse())
-    return true;
+    return false;
 
-  SendResponse(RunWhenValid());
-  return true;
+  return RunWhenValid();
 }
 
 bool FileSystemProviderInternalFunction::Parse() {
   std::string file_system_id;
 
   if (!args_->GetString(0, &file_system_id) ||
       !args_->GetInteger(1, &request_id_)) {
     bad_message_ = true;
-    SendResponse(false);
     return false;
   }
 
   Service* service = Service::Get(GetProfile());
   if (!service) {
-    SendResponse(false);
     return false;
   }
 
   ProvidedFileSystemInterface* file_system =
       service->GetProvidedFileSystem(extension_id(), file_system_id);
   if (!file_system) {
     SetError(FileErrorToString(base::File::FILE_ERROR_NOT_FOUND));
-    SendResponse(false);
     return false;
   }
 
   request_manager_ = file_system->GetRequestManager();
   return true;
 }
 
 }  // namespace extensions