Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 703123002: AXRoleDescriptions are not correctly exposed for dl, dd, dt tags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <execinfo.h> 5 #include <execinfo.h>
6 6
7 #import "content/browser/accessibility/browser_accessibility_cocoa.h" 7 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 case ui::AX_ROLE_ARTICLE: 584 case ui::AX_ROLE_ARTICLE:
585 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 585 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
586 IDS_AX_ROLE_ARTICLE)); 586 IDS_AX_ROLE_ARTICLE));
587 break; 587 break;
588 case ui::AX_ROLE_BANNER: 588 case ui::AX_ROLE_BANNER:
589 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 589 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
590 IDS_AX_ROLE_BANNER)); 590 IDS_AX_ROLE_BANNER));
591 case ui::AX_ROLE_CONTENT_INFO: 591 case ui::AX_ROLE_CONTENT_INFO:
592 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 592 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
593 IDS_AX_ROLE_ADDRESS)); 593 IDS_AX_ROLE_ADDRESS));
594 case ui::AX_ROLE_DESCRIPTION_LIST:
595 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
596 IDS_AX_ROLE_DESCRIPTION_LIST));
597 case ui::AX_ROLE_DESCRIPTION_LIST_DETAIL:
598 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
599 IDS_AX_ROLE_DESCRIPTION_DETAIL));
600 case ui::AX_ROLE_DESCRIPTION_LIST_TERM:
601 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
602 IDS_AX_ROLE_DESCRIPTION_TERM));
594 case ui::AX_ROLE_FOOTER: 603 case ui::AX_ROLE_FOOTER:
595 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 604 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
596 IDS_AX_ROLE_FOOTER)); 605 IDS_AX_ROLE_FOOTER));
597 case ui::AX_ROLE_REGION: 606 case ui::AX_ROLE_REGION:
598 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 607 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
599 IDS_AX_ROLE_REGION)); 608 IDS_AX_ROLE_REGION));
600 case ui::AX_ROLE_SPIN_BUTTON: 609 case ui::AX_ROLE_SPIN_BUTTON:
601 // This control is similar to what VoiceOver calls a "stepper". 610 // This control is similar to what VoiceOver calls a "stepper".
602 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 611 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
603 IDS_AX_ROLE_STEPPER)); 612 IDS_AX_ROLE_STEPPER));
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 722
714 // Returns a subrole based upon the role. 723 // Returns a subrole based upon the role.
715 - (NSString*) subrole { 724 - (NSString*) subrole {
716 ui::AXRole browserAccessibilityRole = [self internalRole]; 725 ui::AXRole browserAccessibilityRole = [self internalRole];
717 if (browserAccessibilityRole == ui::AX_ROLE_TEXT_FIELD && 726 if (browserAccessibilityRole == ui::AX_ROLE_TEXT_FIELD &&
718 GetState(browserAccessibility_, ui::AX_STATE_PROTECTED)) { 727 GetState(browserAccessibility_, ui::AX_STATE_PROTECTED)) {
719 return @"AXSecureTextField"; 728 return @"AXSecureTextField";
720 } 729 }
721 730
722 if (browserAccessibilityRole == ui::AX_ROLE_DESCRIPTION_LIST) 731 if (browserAccessibilityRole == ui::AX_ROLE_DESCRIPTION_LIST)
723 return @"AXDescriptionList"; 732 return @"AXDefinitionList";
724 733
725 if (browserAccessibilityRole == ui::AX_ROLE_LIST) 734 if (browserAccessibilityRole == ui::AX_ROLE_LIST)
726 return @"AXContentList"; 735 return @"AXContentList";
727 736
728 return [AXPlatformNodeCocoa nativeSubroleFromAXRole:browserAccessibilityRole]; 737 return [AXPlatformNodeCocoa nativeSubroleFromAXRole:browserAccessibilityRole];
729 } 738 }
730 739
731 // Returns all tabs in this subtree. 740 // Returns all tabs in this subtree.
732 - (NSArray*)tabs { 741 - (NSArray*)tabs {
733 NSMutableArray* tabSubtree = [[[NSMutableArray alloc] init] autorelease]; 742 NSMutableArray* tabSubtree = [[[NSMutableArray alloc] init] autorelease];
(...skipping 732 matching lines...) Expand 10 before | Expand all | Expand 10 after
1466 return [super hash]; 1475 return [super hash];
1467 return browserAccessibility_->GetId(); 1476 return browserAccessibility_->GetId();
1468 } 1477 }
1469 1478
1470 - (BOOL)accessibilityShouldUseUniqueId { 1479 - (BOOL)accessibilityShouldUseUniqueId {
1471 return YES; 1480 return YES;
1472 } 1481 }
1473 1482
1474 @end 1483 @end
1475 1484
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698