Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 703123002: AXRoleDescriptions are not correctly exposed for dl, dd, dt tags (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AXRoleDescriptions are not correctly exposed for dl, dd, dt tags This is in accordance with latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html dd: MSAA+IA2 Role: IA2_ROLE_PARAGRAPH AX: AXRole: AXGroup AXSubrole: AXDefinition AXRoleDescription: "definition" dl: MSAA+IA2: Role: ROLE_SYSTEM_LIST States: STATE_SYSTEM_READONLY AX: AXRole: AXList AXSubrole: AXDefinitionList AXRoleDescription: "definition list" dt: MSAA+IA2: Role: ROLE_SYSTEM_LISTITEM States: STATE_SYSTEM_READONLY AX: AXRole: AXGroup AXSubrole: AXTerm AXRoleDescription: "term" BUG=430795 Committed: https://crrev.com/16cf3bb5bddbe2bd18f4c13039504e3af6d6d8d6 Cr-Commit-Position: refs/heads/master@{#303601}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : rebasing changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M content/app/strings/content_strings.grd View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/dl.html View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/dl-expected-mac.txt View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M content/test/data/accessibility/dl-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/dt-expected-mac.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/dt-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (2 generated)
shreeramk
@Dominic & @Avi: PTAL. I need inputs on content_strings.grd changes. Thanks.
6 years, 1 month ago (2014-11-06 07:14:50 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd#newcode344 content/app/strings/content_strings.grd:344: <message name="IDS_AX_ROLE_DESCRIPTION_DETAIL" desc="accessibility role description for description, definition ...
6 years, 1 month ago (2014-11-06 07:20:34 UTC) #3
Avi (use Gerrit)
LGTM since dmazzoni is happy
6 years, 1 month ago (2014-11-06 07:21:42 UTC) #4
shreeramk
https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd#newcode348 content/app/strings/content_strings.grd:348: defintion list On 2014/11/06 07:20:34, dmazzoni wrote: > This ...
6 years, 1 month ago (2014-11-06 07:21:46 UTC) #5
dmazzoni
https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd#newcode348 content/app/strings/content_strings.grd:348: defintion list On 2014/11/06 07:21:46, shreeramk wrote: > On ...
6 years, 1 month ago (2014-11-06 07:28:29 UTC) #6
shreeramk
On 2014/11/06 07:28:29, dmazzoni wrote: > https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd > File content/app/strings/content_strings.grd (right): > > https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd#newcode348 > ...
6 years, 1 month ago (2014-11-06 07:43:01 UTC) #7
shreeramk
On 2014/11/06 07:43:01, shreeramk wrote: > On 2014/11/06 07:28:29, dmazzoni wrote: > > > https://codereview.chromium.org/703123002/diff/20001/content/app/strings/content_strings.grd ...
6 years, 1 month ago (2014-11-06 07:45:36 UTC) #8
shreeramk
@Dominic: PTAL. Thanks!!
6 years, 1 month ago (2014-11-10 18:29:04 UTC) #9
dmazzoni
lgtm
6 years, 1 month ago (2014-11-11 06:40:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703123002/60001
6 years, 1 month ago (2014-11-11 06:41:02 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-11 07:43:17 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 07:44:30 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/16cf3bb5bddbe2bd18f4c13039504e3af6d6d8d6
Cr-Commit-Position: refs/heads/master@{#303601}

Powered by Google App Engine
This is Rietveld 408576698