Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 703113003: DevTools: Timeline: speed-up records processing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 796 matching lines...) Expand 10 before | Expand all | Expand 10 after
807 this._lazyFrameModel.addTraceEvents(this._tracingTimelineModel.i nspectedTargetEvents(), this._tracingModel.sessionId()); 807 this._lazyFrameModel.addTraceEvents(this._tracingTimelineModel.i nspectedTargetEvents(), this._tracingModel.sessionId());
808 else 808 else
809 this._lazyFrameModel.addRecords(this._model.records()); 809 this._lazyFrameModel.addRecords(this._model.records());
810 } 810 }
811 if (this._tracingTimelineModel) { 811 if (this._tracingTimelineModel) {
812 this.requestWindowTimes(this._tracingTimelineModel.minimumRecordTime (), this._tracingTimelineModel.maximumRecordTime()); 812 this.requestWindowTimes(this._tracingTimelineModel.minimumRecordTime (), this._tracingTimelineModel.maximumRecordTime());
813 this._refreshViews(); 813 this._refreshViews();
814 } 814 }
815 this._hideProgressPane(); 815 this._hideProgressPane();
816 this._overviewPane.update(); 816 this._overviewPane.update();
817 }, 817 this._updateSearchHighlight(false, true);
818
819 _onRecordAdded: function(event)
820 {
821 this._addRecord(/** @type {!WebInspector.TimelineModel.Record} */(event. data));
822 }, 818 },
823 819
824 /** 820 /**
825 * @param {!WebInspector.TimelineModel.Record} record 821 * @param {!WebInspector.Event} event
826 */ 822 */
827 _addRecord: function(record) 823 _onRecordAdded: function(event)
828 { 824 {
825 /** @type {!WebInspector.TimelineModel.Record} */
apavlov 2014/11/06 09:22:47 You should not need this @type annotation, since y
loislo 2014/11/06 09:41:58 Done.
826 var record = /** @type {!WebInspector.TimelineModel.Record} */ (event.da ta);
829 if (this._lazyFrameModel && !this._tracingModel) 827 if (this._lazyFrameModel && !this._tracingModel)
830 this._lazyFrameModel.addRecord(record); 828 this._lazyFrameModel.addRecord(record);
831 for (var i = 0; i < this._currentViews.length; ++i) 829 for (var i = 0; i < this._currentViews.length; ++i)
832 this._currentViews[i].addRecord(record); 830 this._currentViews[i].addRecord(record);
833 this._updateSearchHighlight(false, true);
834 }, 831 },
835 832
836 /** 833 /**
837 * @param {!WebInspector.Event} event 834 * @param {!WebInspector.Event} event
838 */ 835 */
839 _willReloadPage: function(event) 836 _willReloadPage: function(event)
840 { 837 {
841 if (this._operationInProgress || this._userInitiatedRecording || !this.i sShowing()) 838 if (this._operationInProgress || this._userInitiatedRecording || !this.i sShowing())
842 return; 839 return;
843 this._startRecording(false); 840 this._startRecording(false);
(...skipping 676 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 1517
1521 WebInspector.TimelinePanelFactory.prototype = { 1518 WebInspector.TimelinePanelFactory.prototype = {
1522 /** 1519 /**
1523 * @return {!WebInspector.Panel} 1520 * @return {!WebInspector.Panel}
1524 */ 1521 */
1525 createPanel: function() 1522 createPanel: function()
1526 { 1523 {
1527 return WebInspector.TimelinePanel._instance(); 1524 return WebInspector.TimelinePanel._instance();
1528 } 1525 }
1529 } 1526 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698