Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 703113003: DevTools: Timeline: speed-up records processing. (Closed)

Created:
6 years, 1 month ago by loislo
Modified:
6 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Timeline: speed-up records processing. It was awfully slow because we updated selection and calculated aggregates for every added record. So the complexity was at least n^2. I moved the _updateSearchHighlight call to _onRecordingStopped BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184909

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
loislo
6 years, 1 month ago (2014-11-06 09:20:22 UTC) #2
apavlov
https://codereview.chromium.org/703113003/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/703113003/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode825 Source/devtools/front_end/timeline/TimelinePanel.js:825: /** @type {!WebInspector.TimelineModel.Record} */ You should not need this ...
6 years, 1 month ago (2014-11-06 09:22:47 UTC) #4
loislo
https://codereview.chromium.org/703113003/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/703113003/diff/1/Source/devtools/front_end/timeline/TimelinePanel.js#newcode825 Source/devtools/front_end/timeline/TimelinePanel.js:825: /** @type {!WebInspector.TimelineModel.Record} */ On 2014/11/06 09:22:47, apavlov wrote: ...
6 years, 1 month ago (2014-11-06 09:41:58 UTC) #5
vsevik
lgtm
6 years, 1 month ago (2014-11-06 09:59:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703113003/20001
6 years, 1 month ago (2014-11-06 10:08:16 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 12:01:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184909

Powered by Google App Engine
This is Rietveld 408576698