remoting: Fix response validation error found by PVS Studio.

remoting: Fix response validation error found by PVS Studio.

BUG=83899
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86653

[awong, 2011-05-25 16:39:34]

LGTM

Thanks!

On Wed, May 25, 2011 at 9:38 AM, <thakis@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> remoting: Fix response validation error found by PVS Studio.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/7031055/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M remoting/jingle_glue/iq_request.cc
>
>
> Index: remoting/jingle_glue/iq_request.cc
> diff --git a/remoting/jingle_glue/iq_request.cc
> b/remoting/jingle_glue/iq_request.cc
> index
>
f2751a9523ba190f092543011ed2965daeb73ad3..07d2c81d545a84aede8f7e613d4a1b625eacd412
> 100644
> --- a/remoting/jingle_glue/iq_request.cc
> +++ b/remoting/jingle_glue/iq_request.cc
> @@ -245,7 +245,7 @@ void JingleInfoRequest::OnResponse(const
> buzz::XmlElement* stanza) {
>          server = server->NextNamed(buzz::QN_JINGLE_INFO_SERVER)) {
>       std::string host = server->Attr(buzz::QN_JINGLE_INFO_HOST);
>       std::string port_str = server->Attr(buzz::QN_JINGLE_INFO_UDP);
> -      if (host != buzz::STR_EMPTY && host != buzz::STR_EMPTY) {
> +      if (host != buzz::STR_EMPTY && port_str != buzz::STR_EMPTY) {
>         int port;
>         if (!base::StringToInt(port_str, &port)) {
>           LOG(WARNING) << "Unable to parse port in stanza" <<
> stanza->Str();
>
>
>

[awong, 2011-05-25 16:40:26]

nit: should match the bug number in the BUG#83899 in the review description.

On Wed, May 25, 2011 at 9:39 AM, Albert J. Wong (王重傑)
<ajwong@chromium.org>wrote:

> LGTM
>
> Thanks!
>
>
> On Wed, May 25, 2011 at 9:38 AM, <thakis@chromium.org> wrote:
>
>> Reviewers: awong,
>>
>> Description:
>> remoting: Fix response validation error found by PVS Studio.
>>
>> BUG=none
>> TEST=none
>>
>>
>> Please review this at http://codereview.chromium.org/7031055/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files:
>>  M remoting/jingle_glue/iq_request.cc
>>
>>
>> Index: remoting/jingle_glue/iq_request.cc
>> diff --git a/remoting/jingle_glue/iq_request.cc
>> b/remoting/jingle_glue/iq_request.cc
>> index
>>
f2751a9523ba190f092543011ed2965daeb73ad3..07d2c81d545a84aede8f7e613d4a1b625eacd412
>> 100644
>> --- a/remoting/jingle_glue/iq_request.cc
>> +++ b/remoting/jingle_glue/iq_request.cc
>> @@ -245,7 +245,7 @@ void JingleInfoRequest::OnResponse(const
>> buzz::XmlElement* stanza) {
>>          server = server->NextNamed(buzz::QN_JINGLE_INFO_SERVER)) {
>>       std::string host = server->Attr(buzz::QN_JINGLE_INFO_HOST);
>>       std::string port_str = server->Attr(buzz::QN_JINGLE_INFO_UDP);
>> -      if (host != buzz::STR_EMPTY && host != buzz::STR_EMPTY) {
>> +      if (host != buzz::STR_EMPTY && port_str != buzz::STR_EMPTY) {
>>         int port;
>>         if (!base::StringToInt(port_str, &port)) {
>>           LOG(WARNING) << "Unable to parse port in stanza" <<
>> stanza->Str();
>>
>>
>>
>

[commit-bot: I haz the power, 2011-05-25 18:19:10]

Change committed as 86653