Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 703103003: [turbofan] Combine JSToNumber and ChangeTaggedToFloat64 for fast SMI case. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Combine JSToNumber and ChangeTaggedToFloat64 for fast SMI case. This does the following optimization during ChangeLowering: ChangeTaggedToFloat64(JSToNumber(x)) => if IsSmi(x) then ChangeSmiToFloat64(x) else let y = JSToNumber(x) in if IsSmi(y) then ChangeSmiToFloat64(y) else LoadHeapNumberValue(y) Also cleanup/rearrange some code duplication in ChangeLowering. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -58 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +14 lines, -7 lines 0 comments Download
M src/compiler/change-lowering.cc View 5 chunks +114 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-06 13:19:18 UTC) #2
dcarney
lgtm
6 years, 1 month ago (2014-11-06 13:24:25 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-06 13:25:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698