Fix tweak_info_plist's TOP path to be found relative to itself rather than the includer's SRCROOT.

Fix tweak_info_plist's TOP path to be found relative to itself rather than the includer's SRCROOT.

This allows tweak_info_plist.py to be used from .gyp files that are more than 1 level deep.

BUG=399363
Committed: https://crrev.com/9c23fa4e917e30de4d5d89292fd26e8eb70b8898
Cr-Commit-Position: refs/heads/master@{#303047}

[Yoyo Zhou, 2014-11-06 02:44:05]

yoz@chromium.org changed reviewers:
+ mark@chromium.org

[Yoyo Zhou, 2014-11-06 02:44:06]

P.S. Yes, I'm planning to add a new framework/helper for the
app_shell/app_shell_browsertests target. (It's like Content Shell, but for
running an app.) Would you be able to review that?

[Mark Mentovai, 2014-11-06 04:06:13]

LGTM either way.

https://chromiumcodereview.appspot.com/703073002/diff/1/build/mac/tweak_info_...
File build/mac/tweak_info_plist.py (right):

https://chromiumcodereview.appspot.com/703073002/diff/1/build/mac/tweak_info_...
build/mac/tweak_info_plist.py:32: TOP =
os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(
Not sure the abspath is necessary. Without it, you might just get a bunch of
dots, but that should work.

[Yoyo Zhou, 2014-11-06 17:44:37]

https://chromiumcodereview.appspot.com/703073002/diff/1/build/mac/tweak_info_...
File build/mac/tweak_info_plist.py (right):

https://chromiumcodereview.appspot.com/703073002/diff/1/build/mac/tweak_info_...
build/mac/tweak_info_plist.py:32: TOP =
os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(
On 2014/11/06 04:06:13, Mark Mentovai wrote:
> Not sure the abspath is necessary. Without it, you might just get a bunch of
> dots, but that should work.

Removed the abspath.

[Yoyo Zhou, 2014-11-06 17:44:40]

The CQ bit was checked by yoz@chromium.org

[Mark Mentovai, 2014-11-06 17:45:09]

LGTM

[commit-bot: I haz the power, 2014-11-06 17:45:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703073002/20001

[commit-bot: I haz the power, 2014-11-06 18:25:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-06 18:25:57]

Patchset 2 (id:??) landed as
https://crrev.com/9c23fa4e917e30de4d5d89292fd26e8eb70b8898
Cr-Commit-Position: refs/heads/master@{#303047}