Language.{h,cpp} clean-up.

Language.{h,cpp} clean-up.

- Remove userPreferredLanguagesOverride().  It's unused.
- Rename canonicalizedLanguageIdentifier() to canonicalizeLanguageIdentifier().
- Make sure that platformLanguage() and userPreferredLanguages() return language
  codes with '-'.
- Optimize platformLanguage().  It shouldn't create a Vector every time.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184894

[tkent, 2014-11-06 03:04:31]

tkent@chromium.org changed reviewers:
+ ksakamoto@chromium.org

[tkent, 2014-11-06 03:04:31]

Sakamoto-san, would you review this please?

[Kunihiko Sakamoto, 2014-11-06 03:56:02]

https://codereview.chromium.org/703043002/diff/1/Source/platform/Language.cpp
File Source/platform/Language.cpp (right):

https://codereview.chromium.org/703043002/diff/1/Source/platform/Language.cpp...
Source/platform/Language.cpp:59: {
I don't understand why this implementation is better than old one
(Vector::operator=). Can you explain?

[tkent, 2014-11-06 04:02:21]

https://codereview.chromium.org/703043002/diff/1/Source/platform/Language.cpp
File Source/platform/Language.cpp (right):

https://codereview.chromium.org/703043002/diff/1/Source/platform/Language.cpp...
Source/platform/Language.cpp:59: {
On 2014/11/06 03:56:02, Kunihiko Sakamoto wrote:
> I don't understand why this implementation is better than old one
> (Vector::operator=). Can you explain?

This is not better than the original code.  We need to iterate over items
because we need to apply canonicalizedLanguageIdentifier() to each of items.

[Kunihiko Sakamoto, 2014-11-06 04:03:47]

lgtm

https://codereview.chromium.org/703043002/diff/1/Source/platform/Language.cpp
File Source/platform/Language.cpp (right):

https://codereview.chromium.org/703043002/diff/1/Source/platform/Language.cpp...
Source/platform/Language.cpp:59: {
On 2014/11/06 04:02:21, tkent wrote:
> On 2014/11/06 03:56:02, Kunihiko Sakamoto wrote:
> > I don't understand why this implementation is better than old one
> > (Vector::operator=). Can you explain?
> 
> This is not better than the original code.  We need to iterate over items
> because we need to apply canonicalizedLanguageIdentifier() to each of items.

Oh, I missed that part. Got it, thanks!

[tkent, 2014-11-06 04:05:35]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-11-06 04:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703043002/1

[commit-bot: I haz the power, 2014-11-06 04:08:00]

Committed patchset #1 (id:1) as 184894