Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 703033006: hr tag should return SplitterRole. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
*dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

hr tag should return SplitterRole. Remove redundant role HorizontalRuleRole. HR tag should return SplitterRole. This CL depends on https://codereview.chromium.org/709523002/ BUG=384723 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185053

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/accessibility/AXObject.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebAXEnums.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
shreeramk
Please review. Thanks!
6 years, 1 month ago (2014-11-08 10:42:32 UTC) #2
Mike West
Code change LGTM, but please wait for Dominic to sign off on the logical change; ...
6 years, 1 month ago (2014-11-08 13:43:27 UTC) #4
dmazzoni
lgtm
6 years, 1 month ago (2014-11-10 17:01:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703033006/20001
6 years, 1 month ago (2014-11-10 17:02:29 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 18:05:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185053

Powered by Google App Engine
This is Rietveld 408576698