Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 703023004: Move the JS content handler et al from mojo/apps/js to mojo/services (Closed)

Created:
6 years, 1 month ago by hansmuller
Modified:
6 years, 1 month ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Moved the JS content handler, the gl and monotonic_clock modules from mojo/apps/js to services/js. Added the following main directories: mojo/services/public/js - The JS content handler client module. services/js - The JS content handler implementation. services/js/modules - The gl and clock modules. examples/js - Mostly a TBD. Added js_services_unittests. This should the last big file shuffle for JS in Mojo. BUG=430520 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/11fa7848543fa8060b7e5ca06190849e24cda0a3

Patch Set 1 #

Patch Set 2 : Moved mojo/services/js to services/js #

Total comments: 4

Patch Set 3 : Fixed DEPS gl build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1149 lines) Patch
A + examples/js/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
D mojo/apps/js/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/apps/js/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/apps/js/bindings/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/apps/js/bindings/gl/context.h View 1 chunk +0 lines, -77 lines 0 comments Download
D mojo/apps/js/bindings/gl/context.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D mojo/apps/js/bindings/gl/module.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/apps/js/bindings/gl/module.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/apps/js/bindings/monotonic_clock.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/apps/js/bindings/monotonic_clock.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/apps/js/bindings/monotonic_clock_unittests.js View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/apps/js/content_handler_main.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/apps/js/js_app.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/apps/js/js_app.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D mojo/apps/js/main.js View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/apps/js/mojo.js View 1 chunk +0 lines, -169 lines 0 comments Download
D mojo/apps/js/mojo_bridge_module.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/apps/js/mojo_bridge_module.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/apps/js/test/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/apps/js/test/run_apps_js_tests.cc View 1 chunk +0 lines, -54 lines 0 comments Download
A + mojo/services/public/js/mojo.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +1 line, -0 lines 0 comments Download
M services/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + services/js/BUILD.gn View 1 1 chunk +19 lines, -16 lines 0 comments Download
A services/js/DEPS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A + services/js/content_handler_main.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + services/js/js_app.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + services/js/js_app.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + services/js/modules/clock/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/modules/clock/monotonic_clock.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + services/js/modules/clock/monotonic_clock.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + services/js/modules/clock/monotonic_clock_unittests.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/modules/clock/test/BUILD.gn View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + services/js/modules/clock/test/run_clock_tests.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
A + services/js/modules/gl/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
A + services/js/modules/gl/context.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/modules/gl/context.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + services/js/modules/gl/module.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + services/js/modules/gl/module.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + services/js/mojo_bridge_module.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
A + services/js/mojo_bridge_module.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hansmuller
PTAL. Notes: - My GN skills are still pretty lame. - I put a DEPS ...
6 years, 1 month ago (2014-11-07 22:37:17 UTC) #2
Ben Goodger (Google)
drive-by: you should move this into //services not //mojo/services. //mojo/services is deprecated and will die ...
6 years, 1 month ago (2014-11-08 01:11:57 UTC) #4
hansmuller
On 2014/11/08 01:11:57, Ben Goodger (Google) wrote: > drive-by: you should move this into //services ...
6 years, 1 month ago (2014-11-10 15:56:30 UTC) #5
jamesr
lgtm https://codereview.chromium.org/703023004/diff/20001/services/js/DEPS File services/js/DEPS (right): https://codereview.chromium.org/703023004/diff/20001/services/js/DEPS#newcode4 services/js/DEPS:4: "+mojo/application", please sort this list https://codereview.chromium.org/703023004/diff/20001/services/js/modules/gl/BUILD.gn File services/js/modules/gl/BUILD.gn ...
6 years, 1 month ago (2014-11-10 18:35:53 UTC) #6
hansmuller
Thanks for looking through all FIVE of these! https://codereview.chromium.org/703023004/diff/20001/services/js/DEPS File services/js/DEPS (right): https://codereview.chromium.org/703023004/diff/20001/services/js/DEPS#newcode4 services/js/DEPS:4: "+mojo/application", ...
6 years, 1 month ago (2014-11-10 18:59:16 UTC) #7
hansmuller
Thanks for looking through all FIVE of these!
6 years, 1 month ago (2014-11-10 18:59:20 UTC) #8
hansmuller
6 years, 1 month ago (2014-11-10 19:03:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
11fa7848543fa8060b7e5ca06190849e24cda0a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698