Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 702943003: MSAA + (IA,IA2) role are not correctly exposed for html footer tag. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MSAA + (IA,IA2) role are not correctly exposed for html footer tag. According to specs http://rawgit.com/w3c/aria/master/html-aam/html-aam.html For html footer tag, MSAA+IA Role: ROLE_SYSTEM_GROUPING MSAA+IA2 Role: Role: IA2_ROLE_FOOTER Also, there should be no STATE_SYSTEM_READONLY. Committed: https://crrev.com/435016b55977c201df289fec02e9b48b253025ae Cr-Commit-Position: refs/heads/master@{#303604}

Patch Set 1 #

Patch Set 2 : updating landmark expectation for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/footer-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/landmark-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
@dmazzoni & @aboxhall: Please review. Thanks!
6 years, 1 month ago (2014-11-10 18:49:47 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-11 06:39:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702943003/20001
6 years, 1 month ago (2014-11-11 06:40:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 07:45:19 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 07:46:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/435016b55977c201df289fec02e9b48b253025ae
Cr-Commit-Position: refs/heads/master@{#303604}

Powered by Google App Engine
This is Rietveld 408576698