Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 702913002: Updating custom scrollbar style (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressed review comments by rune Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 63c7faa24d53d41603d8cea36476da2ffbb9c253..2831235bb74e10dd17042f86bff1e654334118ee 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -323,6 +323,26 @@ void FrameView::detachCustomScrollbars()
}
}
+void FrameView::recalculateCustomScrollbarStyle()
+{
+ if (hasCustomScrollbars()) {
skobes 2014/11/07 17:54:41 You don't need this check since you are checking i
MuVen 2014/11/07 18:31:19 Done.
MuVen 2014/11/07 18:31:19 Done.
+ bool didStyleRecalculated = false;
skobes 2014/11/07 17:54:41 Call this "didStyleChange".
MuVen 2014/11/07 18:31:19 Done.
+ if (m_horizontalScrollbar && m_horizontalScrollbar->isCustomScrollbar()) {
+ m_horizontalScrollbar->styleChanged();
+ didStyleRecalculated = true;
+ }
+ if (m_verticalScrollbar && m_verticalScrollbar->isCustomScrollbar()) {
+ m_verticalScrollbar->styleChanged();
+ didStyleRecalculated = true;
+ }
+ if (didStyleRecalculated) {
+ updateScrollbarGeometry();
+ updateScrollCorner();
+ positionScrollbarLayers();
+ }
+ }
+}
+
void FrameView::recalculateScrollbarOverlayStyle()
{
ScrollbarOverlayStyle oldOverlayStyle = scrollbarOverlayStyle();

Powered by Google App Engine
This is Rietveld 408576698