LayoutTests/scrollbars/custom-scrollbar-changing-style.html - Issue 702913002: Updating custom scrollbar style

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/scrollbars/custom-scrollbar-changing-style.html

Issue 702913002: Updating custom scrollbar style (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 ::-webkit-scrollbar {

	4 height: 10px;

	5 width: 10px

	6 }

	7 ::-webkit-scrollbar-thumb {

	8 background: rgba(255,0,0,0.8);

	9 }

	10 html {

	11 overflow-y: scroll;

	12 }

	13 </style>

	14 <script>

	15 if (window.testRunner)

	16 testRunner.waitUntilDone();

	17 function addstyle(){

	18 var addRule = (function(style){

	19 var sheet = document.head.appendChild(style).sheet;
	skobes 2014/11/07 00:13:59 I think this would be easier to understand if the I think this would be easier to understand if the calls to createElement and appendChild were moved above the addRule initializer, e.g.: var styleElement = document.createElement("style"); document.head.appendChild(styleElement); var addRule = function(selector, properties) { ... }; MuVen 2014/11/07 09:46:59 Done. Show quoted text On 2014/11/07 00:13:59, skobes wrote: > I think this would be easier to understand if the calls to createElement and > appendChild were moved above the addRule initializer, e.g.: > > var styleElement = document.createElement("style"); > document.head.appendChild(styleElement); > var addRule = function(selector, properties) { > ... > }; Done.
	20 return function(selector, css){

	21 var propText = Object.keys(css).map(function(p){

	22 return p+":"+css[p]

	23 }).join(";");

	24 sheet.insertRule(selector + "{" + propText + "}", sheet.cssRules.len gth);

	25 }

	26 })(document.createElement("style"));

	27

	28 addRule("::-webkit-scrollbar-thumb", {

	29 background: "rgba(13,53,178,0.8)",

	30 });

	31 if (window.testRunner)

	32 testRunner.notifyDone();

	33 };

	34 setTimeout(function() {addstyle();}, 1);

	35 </script>

	36 <div style="height:700px"></div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/scrollbars/custom-scrollbar-changing-style-expected.html » ('j') | Source/core/frame/FrameView.cpp » ('J')