LayoutTests/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html - Issue 702913002: Updating custom scrollbar style

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash.html

Issue 702913002: Updating custom scrollbar style (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added new test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/scrollbars/custom-scrollbar-changing-style.html ('K') | « LayoutTests/scrollbars/custom-scrollbar-changing-style-expected.txt ('k') | LayoutTests/scrollbars/custom-scrollbar-thickness-change-on-zoom-crash-expected.txt » ('j') | Source/core/frame/FrameView.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 ::-webkit-scrollbar {

	4 height: 1px;

	5 width: 1px

	6 }

	7 html {

	8 overflow-y: scroll

	9 }

	10 </style>

	11 <script>

	12 if (window.testRunner) {

	13 testRunner.dumpAsText();

	14 testRunner.waitUntilDone();

	15 }

	16 eventSender.setPageZoomFactor(2.5);

	17 if (window.testRunner)

	18 testRunner.notifyDone();
	rune 2014/11/06 16:44:27 Do you really need a wait/notify here? If so, won' Do you really need a wait/notify here? If so, won't this be too early? MuVen 2014/11/06 18:49:55 not needed. removed. Done. Show quoted text On 2014/11/06 16:44:27, rune wrote: > Do you really need a wait/notify here? If so, won't this be too early? not needed. removed. Done.
	19 </script>

	20 <div>

	21 Custom-Scrollbar needs layout when scrollbar thickness changed.

	22 <span>The test passed if chrome did not crash.</span>

	23 </div>

	24 <ul>

	25 <li>Chrome did not crash</li>

	26 <li>Chrome did not crash</li>

	27 <li>Chrome did not crash</li>

	28 <li>Chrome did not crash</li>

	29 <li>Chrome did not crash</li>

	30 <li>Chrome did not crash</li>

	31 <li>Chrome did not crash</li>

	32 <li>Chrome did not crash</li>

	33 <li>Chrome did not crash</li>

	34 <li>Chrome did not crash</li>
	rune 2014/11/06 16:44:27 Was this list necessary? Was this list necessary? MuVen 2014/11/06 17:35:15 well the list is created, just when the page is zo Show quoted text On 2014/11/06 16:44:27, rune wrote: > Was this list necessary? well the list is created, just when the page is zoomed from 0 to 2.5 scale will enable scrollbar. MuVen 2014/11/06 18:49:55 Done. Show quoted text On 2014/11/06 17:35:15, muven wrote: > On 2014/11/06 16:44:27, rune wrote: > > Was this list necessary? > > well the list is created, just when the page is zoomed from 0 to 2.5 > scale will enable scrollbar. Done.
	35 </ul>

OLD	NEW