Add chrome perf tests and sniffer to GN build.

Add chrome perf tests to GN build, fix harfbuzz

This also hooks up the chrome test support target which was previously not compiled (the file wasn't referenced).

This duplicates the harfbuzz logic from the GYP build where the system one is conditionally used if the pangoft2 version is sufficiently large. There are some additions to the pkg-config wrapper script to check versions.

Write a service_discovery_sniffer target but don't hook it up. Currently this gives linker errors.

Fix grit warnings for the remoting resources.

R=dpranke@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/32ce17ab53d97a66e50e7e49ef57e8fa9f881714

[brettw, 2014-11-05 21:28:39]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2014-11-05 21:28:40]

I could have done some work to pare down the definition of the GYP perf_tests
target, but decided it's not worth it. It looks like this target should just be
deleted at some point.

https://codereview.chromium.org/702903004/diff/20001/chrome/test/perf/perftes...
File chrome/test/perf/perftests.cc (left):

https://codereview.chromium.org/702903004/diff/20001/chrome/test/perf/perftes...
chrome/test/perf/perftests.cc:11: chrome::RegisterPathProvider();
This appears to be unnecessary for the current set of tests, and required that a
bunch of chrome dependencies are linked in.

[Dirk Pranke, 2014-11-05 21:36:13]

lgtm

[brettw, 2014-11-05 21:48:05]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-11-05 21:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702903004/20001

[brettw, 2014-11-05 22:16:14]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-11-05 22:17:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702903004/40001

[commit-bot: I haz the power, 2014-11-05 23:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-05 23:00:54]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2014-11-06 17:35:45]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-11-06 17:36:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702903004/60001

[commit-bot: I haz the power, 2014-11-06 18:00:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 18:00:45]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2014-11-07 21:09:37]

Most recent patch includes some random build fixes that this turned up. There
were some missing files in test support targets, and some missing deps in other
cases.

[brettw, 2014-11-07 21:09:40]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-11-07 21:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/702903004/80001

[commit-bot: I haz the power, 2014-11-07 21:31:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 21:31:48]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2014-11-08 01:08:42]

Dirk: please look again. the harfbuzz and pkg-config stuff is all new.

This comments out the service discovery target which the bots kept barfing on
despite it compiling fine for me locally.

I added a bunch of other fixes I did in the process of trying to diagnose this
problem. They're the remoting resources and harfbuzz changes described in the CL
description.

[Dirk Pranke, 2014-11-08 01:27:13]

lgtm. Also a question (but lgtm regardless of how you answer).

https://codereview.chromium.org/702903004/diff/100001/third_party/harfbuzz-ng...
File third_party/harfbuzz-ng/BUILD.gn (right):

https://codereview.chromium.org/702903004/diff/100001/third_party/harfbuzz-ng...
third_party/harfbuzz-ng/BUILD.gn:18: # over, so it use the system one by
default.
you probably already realize this, but if you build w/ os="chromeos" on Precise,
we get the system harfbuzz, which is too old, and so we have to override this
default on the bots.

I would say this is moot since devs are mostly all on Trusty now, but it's not
clear when the bots will be updated.

Think it's worth changing this logic somehow to account for this, or just force
callers to specify the flag when needed?

[brettw, 2014-11-10 17:38:01]

I'm inclined to punt on the ChromeOS-build-on-old-distro until it comes up.
Thanks for pointing that out.

[commit-bot: I haz the power, 2014-11-10 17:46:48]

Patchset 6 (id:??) landed as
https://crrev.com/32ce17ab53d97a66e50e7e49ef57e8fa9f881714
Cr-Commit-Position: refs/heads/master@{#303489}

[brettw, 2014-11-10 17:46:53]

Committed patchset #6 (id:100001) manually as
32ce17ab53d97a66e50e7e49ef57e8fa9f881714 (presubmit successful).