Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 702893003: Add -ftrapv to debug builds. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add -ftrapv to debug builds. This adds instrumentation to check that signed integers never under- or overflow, which is undefined behavior. BUG=skia:3096 Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gyp/common_conditions.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein
6 years, 1 month ago (2014-11-05 15:28:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702893003/1
6 years, 1 month ago (2014-11-05 15:29:45 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-05 15:29:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/469)
6 years, 1 month ago (2014-11-05 15:42:17 UTC) #7
mtklein
lgtm
6 years ago (2014-11-21 22:09:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/702893003/1
6 years ago (2014-11-21 22:10:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c
6 years ago (2014-11-21 22:24:08 UTC) #11
mtklein
6 years ago (2014-11-21 22:42:00 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/751713002/ by mtklein@google.com.

The reason for reverting is: Not clean yet..

Powered by Google App Engine
This is Rietveld 408576698