include/core/SkDynamicAnnotations.h - Issue 702883002: Whitelist intentionally racy TRACE_EVENT reads and writes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkDynamicAnnotations.h

Issue 702883002: Whitelist intentionally racy TRACE_EVENT reads and writes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: this volatile makes no sense. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkDynamicAnnotations.h

diff --git a/include/core/SkDynamicAnnotations.h b/include/core/SkDynamicAnnotations.h

index 422d98db43d2f92bcb049872cec24db33c012c51..872a292e5dae9075c9e5a69978ed379389646dc4 100644

--- a/include/core/SkDynamicAnnotations.h

+++ b/include/core/SkDynamicAnnotations.h

@@ -42,7 +42,7 @@ inline T SK_ANNOTATE_UNPROTECTED_READ(const volatile T& x) {

// Like SK_ANNOTATE_UNPROTECTED_READ, but for writes.

template <typename T>

-inline void SK_ANNOTATE_UNPROTECTED_WRITE(T* ptr, const volatile T& val) {

+inline void SK_ANNOTATE_UNPROTECTED_WRITE(T* ptr, const T& val) {

AnnotateIgnoreWritesBegin(__FILE__, __LINE__);

*ptr = val;

AnnotateIgnoreWritesEnd(__FILE__, __LINE__);

« no previous file with comments | « no previous file | src/core/SkTraceEvent.h » ('j') | no next file with comments »